Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-02-02 Thread Radim Krčmář
2015-02-02 15:28+0100, Paolo Bonzini: > > > On 02/02/2015 15:26, Radim Krčmář wrote: > >>> > > + return ((logical_id >> 4) == (mda >> 4)) > >>> > > +&& (logical_id & mda & 0xf); > > was merged as > > > > + return ((logical_id >> 4) == (mda >> 4)) > > +

Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-02-02 Thread Radim Krčmář
2015-02-02 15:26+0100, Radim Krčmář: > 2015-01-30 09:52+0100, Paolo Bonzini: > + return ((logical_id >> 4) == (mda >> 4)) > +&& (logical_id & mda & 0xf) != 0; > > but it has to be parenthesized ('&&' has lower precedence than '!='). No, my bad, I understood it now.

Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-02-02 Thread Paolo Bonzini
On 02/02/2015 15:26, Radim Krčmář wrote: >>> > > + return ((logical_id >> 4) == (mda >> 4)) >>> > > + && (logical_id & mda & 0xf); > was merged as > > + return ((logical_id >> 4) == (mda >> 4)) > +&& (logical_id & mda & 0xf) != 0

Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-02-02 Thread Radim Krčmář
2015-01-30 09:52+0100, Paolo Bonzini: > On 29/01/2015 22:48, Radim Krčmář wrote: > > The majority of this patch turns > > result = 0; if (CODE) result = 1; return result; > > into > > return CODE; > > because we return bool now. > > Added a bunch of "!= 0" to avoid automagic conversion to bool

Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-01-30 Thread Radim Krčmář
2015-01-30 09:52+0100, Paolo Bonzini: > On 29/01/2015 22:48, Radim Krčmář wrote: > > The majority of this patch turns > > result = 0; if (CODE) result = 1; return result; > > into > > return CODE; > > because we return bool now. > > Added a bunch of "!= 0" to avoid automagic conversion to bool

Re: [PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-01-30 Thread Paolo Bonzini
On 29/01/2015 22:48, Radim Krčmář wrote: > The majority of this patch turns > result = 0; if (CODE) result = 1; return result; > into > return CODE; > because we return bool now. Added a bunch of "!= 0" to avoid automagic conversion to bool. Paolo > Signed-off-by: Radim Krčmář > --- > ar

[PATCH 2/8] KVM: x86: cleanup kvm_apic_match_*()

2015-01-29 Thread Radim Krčmář
The majority of this patch turns result = 0; if (CODE) result = 1; return result; into return CODE; because we return bool now. Signed-off-by: Radim Krčmář --- arch/x86/kvm/lapic.c | 44 +++- 1 file changed, 15 insertions(+), 29 deletions(-) diff --gi