Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-12 Thread Logan Gunthorpe
On 12/06/18 09:48 AM, Jon Mason wrote: > ntb.c is more of a glue layer, and this is more device specific. > While I like adding it here for more common code, it should probably > reside in the ntb_hw_*.c files to enforce the hw specific code all > reside in that layer. So, this probably needs

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-12 Thread Logan Gunthorpe
On 12/06/18 09:48 AM, Jon Mason wrote: > ntb.c is more of a glue layer, and this is more device specific. > While I like adding it here for more common code, it should probably > reside in the ntb_hw_*.c files to enforce the hw specific code all > reside in that layer. So, this probably needs

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-12 Thread Jon Mason
On Fri, Jun 8, 2018 at 8:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-11 Thread Dave Jiang
On 06/08/2018 05:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the monolithic

Re: [PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-11 Thread Dave Jiang
On 06/08/2018 05:08 PM, Logan Gunthorpe wrote: > Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB > devices") added code to set the DMA mask for the NTB device > to each driver individually. However, it neglected to set it for the > Switchtec driver. So when the monolithic

[PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-08 Thread Logan Gunthorpe
Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB devices") added code to set the DMA mask for the NTB device to each driver individually. However, it neglected to set it for the Switchtec driver. So when the monolithic commit 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port

[PATCH 2/8] NTB: Setup the DMA mask globally for all drivers

2018-06-08 Thread Logan Gunthorpe
Commit 417cf39cfea9 ("NTB: Set dma mask and dma coherent mask to NTB devices") added code to set the DMA mask for the NTB device to each driver individually. However, it neglected to set it for the Switchtec driver. So when the monolithic commit 7f46c8b3a552 ("NTB: ntb_tool: Add full multi-port