Re: [PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath

2016-07-21 Thread Vlastimil Babka
On 07/20/2016 12:28 AM, David Rientjes wrote: On Mon, 18 Jul 2016, Vlastimil Babka wrote: In __alloc_pages_slowpath(), alloc_flags doesn't change after it's initialized, so move the initialization above the retry: label. Also make the comment above the initialization more descriptive. The only

Re: [PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath

2016-07-19 Thread David Rientjes
On Mon, 18 Jul 2016, Vlastimil Babka wrote: > In __alloc_pages_slowpath(), alloc_flags doesn't change after it's > initialized, > so move the initialization above the retry: label. Also make the comment above > the initialization more descriptive. > > The only exception in the alloc_flags being

Re: [PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath

2016-07-18 Thread Michal Hocko
On Mon 18-07-16 13:22:56, Vlastimil Babka wrote: > In __alloc_pages_slowpath(), alloc_flags doesn't change after it's > initialized, > so move the initialization above the retry: label. Also make the comment above > the initialization more descriptive. > > The only exception in the alloc_flags be

[PATCH 2/8] mm, page_alloc: set alloc_flags only once in slowpath

2016-07-18 Thread Vlastimil Babka
In __alloc_pages_slowpath(), alloc_flags doesn't change after it's initialized, so move the initialization above the retry: label. Also make the comment above the initialization more descriptive. The only exception in the alloc_flags being constant is ALLOC_NO_WATERMARKS, which may change due to T