Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-03 Thread Namhyung Kim
On Thu, Mar 03, 2016 at 02:40:33PM +0100, Jiri Olsa wrote: > On Thu, Mar 03, 2016 at 01:12:02AM +0900, Namhyung Kim wrote: > > The perf_hpp__setup_hists_formats() is to build hists-specific output > > formats (and sort keys). Currently it's only used in order to build the > > output format in a hi

Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-03 Thread Namhyung Kim
Hi Jiri, On Thu, Mar 03, 2016 at 02:40:22PM +0100, Jiri Olsa wrote: > On Thu, Mar 03, 2016 at 01:12:02AM +0900, Namhyung Kim wrote: > > SNIP > > > +struct perf_hpp_fmt *perf_hpp_fmt__copy(struct perf_hpp_fmt *fmt); > > + > > int hist_entry__filter(struct hist_entry *he, int type, const void *ar

Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-03 Thread Jiri Olsa
On Thu, Mar 03, 2016 at 01:12:02AM +0900, Namhyung Kim wrote: SNIP > +struct perf_hpp_fmt *perf_hpp_fmt__copy(struct perf_hpp_fmt *fmt); > + > int hist_entry__filter(struct hist_entry *he, int type, const void *arg); > > static inline bool perf_hpp__should_skip(struct perf_hpp_fmt *format, >

Re: [PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-03 Thread Jiri Olsa
On Thu, Mar 03, 2016 at 01:12:02AM +0900, Namhyung Kim wrote: > The perf_hpp__setup_hists_formats() is to build hists-specific output > formats (and sort keys). Currently it's only used in order to build the > output format in a hierarchy with same sort keys, but it could be used > with different

[PATCH 2/8] perf tools: Introduce perf_hpp__setup_hists_formats()

2016-03-02 Thread Namhyung Kim
The perf_hpp__setup_hists_formats() is to build hists-specific output formats (and sort keys). Currently it's only used in order to build the output format in a hierarchy with same sort keys, but it could be used with different sort keys in non-hierarchy mode later. Signed-off-by: Namhyung Kim -