Re: [PATCH 2/8] security: apparmor: Use a more current logging style

2014-02-26 Thread Joe Perches
On Tue, 2014-02-25 at 23:31 -0800, John Johansen wrote: > On 02/24/2014 01:59 PM, Joe Perches wrote: > > Convert printks to pr_. > > Add pr_fmt. > > Coalesce formats. > > Remove embedded prefixes from logging. > > > > you missed one place, No, not really. pr_debug differs from printk(KERN_DEBUG

Re: [PATCH 2/8] security: apparmor: Use a more current logging style

2014-02-25 Thread John Johansen
On 02/24/2014 01:59 PM, Joe Perches wrote: > Convert printks to pr_. > Add pr_fmt. > Coalesce formats. > Remove embedded prefixes from logging. > you missed one place, --- a/security/apparmor/include/apparmor.h +++ b/security/apparmor/include/apparmor.h @@ -50,7 +50,7 @@ extern unsigned int aa_g

[PATCH 2/8] security: apparmor: Use a more current logging style

2014-02-24 Thread Joe Perches
Convert printks to pr_. Add pr_fmt. Coalesce formats. Remove embedded prefixes from logging. Signed-off-by: Joe Perches --- security/apparmor/apparmorfs.c | 2 ++ security/apparmor/crypto.c | 2 ++ security/apparmor/include/apparmor.h | 2 +- security/apparmor/lib.c