Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 06:15:05PM +, Liang, Kan wrote: > > > > > > > Do you have a V2 patch already? I'm asking is because you once > > > mentioned it... :) > > > > No, and I also don't have PPERF hardware, etc, so there's not really much I > > can do. Feel free to do whatever you like

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 11:15 AM, Liang, Kan wrote: > >> > >> > Do you have a V2 patch already? I'm asking is because you once >> > mentioned it... :) >> >> No, and I also don't have PPERF hardware, etc, so there's not really much I >> can do. Feel free to do whatever you like with my v1. >> >

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
> > > > Do you have a V2 patch already? I'm asking is because you once > > mentioned it... :) > > No, and I also don't have PPERF hardware, etc, so there's not really much I > can do. Feel free to do whatever you like with my v1. > OK. I will add my code based on V1, and send it back to you.

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 10:52 AM, Liang, Kan wrote: > > >> >> On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan wrote: >> > >> > >> >> On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: >> >> > On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: >> >> > > > diff --git

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
> > On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan wrote: > > > > > >> On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: > >> > On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: > >> > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c > >> > > >

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan wrote: > > >> On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: >> > On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: >> > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c >> > > >

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
> On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: > > On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: > > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c > > > > b/arch/x86/kernel/cpu/perf_event_intel.c > > > > index b9826a9..651a86d 100644 > > > > ---

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: > On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c > > > b/arch/x86/kernel/cpu/perf_event_intel.c > > > index b9826a9..651a86d 100644 > > > ---

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: > > diff --git a/arch/x86/kernel/cpu/perf_event_intel.c > > b/arch/x86/kernel/cpu/perf_event_intel.c > > index b9826a9..651a86d 100644 > > --- a/arch/x86/kernel/cpu/perf_event_intel.c > > +++ b/arch/x86/kernel/cpu/perf_event_intel.c >

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:44PM +0100, kan.li...@intel.com wrote: > From: Kan Liang > > This patch implements core_misc PMU disable and enable functions. > core_misc PMU counters are free running counters, so it's impossible to > stop/start them. Doesn't that effectively mean you can't group

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Mark Rutland
On Thu, Jul 16, 2015 at 09:33:44PM +0100, kan.li...@intel.com wrote: From: Kan Liang kan.li...@intel.com This patch implements core_misc PMU disable and enable functions. core_misc PMU counters are free running counters, so it's impossible to stop/start them. Doesn't that effectively mean

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c index b9826a9..651a86d 100644 --- a/arch/x86/kernel/cpu/perf_event_intel.c +++ b/arch/x86/kernel/cpu/perf_event_intel.c @@ -1586,6

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c index b9826a9..651a86d 100644 ---

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git a/arch/x86/kernel/cpu/perf_event_intel.c b/arch/x86/kernel/cpu/perf_event_intel.c index b9826a9..651a86d 100644 ---

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan kan.li...@intel.com wrote: On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git a/arch/x86/kernel/cpu/perf_event_intel.c

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 11:15 AM, Liang, Kan kan.li...@intel.com wrote: Do you have a V2 patch already? I'm asking is because you once mentioned it... :) No, and I also don't have PPERF hardware, etc, so there's not really much I can do. Feel free to do whatever you like with my v1.

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan kan.li...@intel.com wrote: On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git a/arch/x86/kernel/cpu/perf_event_intel.c

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Andy Lutomirski
On Fri, Jul 17, 2015 at 10:52 AM, Liang, Kan kan.li...@intel.com wrote: On Fri, Jul 17, 2015 at 8:35 AM, Liang, Kan kan.li...@intel.com wrote: On Fri, Jul 17, 2015 at 03:46:29PM +0200, Peter Zijlstra wrote: On Fri, Jul 17, 2015 at 01:11:41PM +0100, Mark Rutland wrote: diff --git

RE: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Liang, Kan
Do you have a V2 patch already? I'm asking is because you once mentioned it... :) No, and I also don't have PPERF hardware, etc, so there's not really much I can do. Feel free to do whatever you like with my v1. OK. I will add my code based on V1, and send it back to you. I don't

Re: [PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-17 Thread Peter Zijlstra
On Fri, Jul 17, 2015 at 06:15:05PM +, Liang, Kan wrote: Do you have a V2 patch already? I'm asking is because you once mentioned it... :) No, and I also don't have PPERF hardware, etc, so there's not really much I can do. Feel free to do whatever you like with my v1. OK.

[PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-16 Thread kan . liang
From: Kan Liang This patch implements core_misc PMU disable and enable functions. core_misc PMU counters are free running counters, so it's impossible to stop/start them. The "disable" means not read counters. With disable/enable functions, it's possible to "disable" core_misc events when other

[PATCH 2/9] perf/x86: core_misc PMU disable and enable support

2015-07-16 Thread kan . liang
From: Kan Liang kan.li...@intel.com This patch implements core_misc PMU disable and enable functions. core_misc PMU counters are free running counters, so it's impossible to stop/start them. The disable means not read counters. With disable/enable functions, it's possible to disable core_misc