Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-30 Thread Huang Ying
On Tue, 2012-10-30 at 22:38 -0400, Theodore Ts'o wrote: > On Wed, Oct 31, 2012 at 09:35:37AM +0800, Huang Ying wrote: > > > > The intention of lib/uuid.c is to unify various UUID related code, and > > put them in same place. In addition to UUID generation, it provide some > > other utility and ma

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-30 Thread Theodore Ts'o
On Wed, Oct 31, 2012 at 09:35:37AM +0800, Huang Ying wrote: > > The intention of lib/uuid.c is to unify various UUID related code, and > put them in same place. In addition to UUID generation, it provide some > other utility and may provide/collect more in the future. So do you > think it is a g

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-30 Thread Huang Ying
On Tue, 2012-10-30 at 00:48 -0400, Theodore Ts'o wrote: > On Tue, Oct 30, 2012 at 09:49:58AM +0800, Huang Ying wrote: > > The uuid_le/be_gen() in lib/uuid.c has set UUID variants to be DCE, > > that is done in __uuid_gen_common() with "b[8] = (b[8] & 0x3F) | 0x80". > > Oh, I see, I missed that. >

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-29 Thread Theodore Ts'o
On Tue, Oct 30, 2012 at 09:49:58AM +0800, Huang Ying wrote: > The uuid_le/be_gen() in lib/uuid.c has set UUID variants to be DCE, > that is done in __uuid_gen_common() with "b[8] = (b[8] & 0x3F) | 0x80". Oh, I see, I missed that. > To deal with random number generation issue, how about use > get_

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-29 Thread Huang Ying
On Mon, 2012-10-29 at 16:52 -0400, Theodore Ts'o wrote: > On Sun, Oct 28, 2012 at 04:18:59PM +0900, Akinobu Mita wrote: > > Use random32_get_bytes() to generate 16 bytes of pseudo-random bytes. > > > > Signed-off-by: Akinobu Mita > > Since your patch is going to allow users to set the random see

Re: [PATCH 2/9] uuid: use random32_get_bytes()

2012-10-29 Thread Theodore Ts'o
On Sun, Oct 28, 2012 at 04:18:59PM +0900, Akinobu Mita wrote: > Use random32_get_bytes() to generate 16 bytes of pseudo-random bytes. > > Signed-off-by: Akinobu Mita Since your patch is going to allow users to set the random seed, it means that what had previously been a bad security bug has jus

[PATCH 2/9] uuid: use random32_get_bytes()

2012-10-28 Thread Akinobu Mita
Use random32_get_bytes() to generate 16 bytes of pseudo-random bytes. Signed-off-by: Akinobu Mita --- lib/uuid.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/uuid.c b/lib/uuid.c index 52a6fe6..697f867 100644 --- a/lib/uuid.c +++ b/lib/uuid.c @@ -25,13 +25,7 @@