Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 19:19:28, Konstantin Khlebnikov wrote: > > > On 05.11.2018 16:03, Vlastimil Babka wrote: > > On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: > > > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > > > > > Signed-off-by: Konstantin Khlebnikov > > > >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Michal Hocko
On Mon 05-11-18 19:19:28, Konstantin Khlebnikov wrote: > > > On 05.11.2018 16:03, Vlastimil Babka wrote: > > On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: > > > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > > > > > Signed-off-by: Konstantin Khlebnikov > > > >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Vlastimil Babka
On 11/5/18 5:19 PM, Konstantin Khlebnikov wrote: > > > On 05.11.2018 16:03, Vlastimil Babka wrote: >> On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: >>> Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. >>> >>> Signed-off-by: Konstantin Khlebnikov >> >> Makes sense

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Vlastimil Babka
On 11/5/18 5:19 PM, Konstantin Khlebnikov wrote: > > > On 05.11.2018 16:03, Vlastimil Babka wrote: >> On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: >>> Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. >>> >>> Signed-off-by: Konstantin Khlebnikov >> >> Makes sense

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Konstantin Khlebnikov
On 05.11.2018 16:03, Vlastimil Babka wrote: On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. Signed-off-by: Konstantin Khlebnikov Makes sense regardless of warnings stuff. Acked-by: Vlastimil Babka But it must be

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Konstantin Khlebnikov
On 05.11.2018 16:03, Vlastimil Babka wrote: On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. Signed-off-by: Konstantin Khlebnikov Makes sense regardless of warnings stuff. Acked-by: Vlastimil Babka But it must be

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Vlastimil Babka
On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > Signed-off-by: Konstantin Khlebnikov Makes sense regardless of warnings stuff. Acked-by: Vlastimil Babka But it must be moved below the GFP_KERNEL check! > --- >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-05 Thread Vlastimil Babka
On 11/1/18 11:09 AM, Konstantin Khlebnikov wrote: > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > Signed-off-by: Konstantin Khlebnikov Makes sense regardless of warnings stuff. Acked-by: Vlastimil Babka But it must be moved below the GFP_KERNEL check! > --- >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 19:42:48, Konstantin Khlebnikov wrote: > On 01.11.2018 15:55, Michal Hocko wrote: > > On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: > > > > > > > > > On 01.11.2018 13:24, Michal Hocko wrote: > > > > On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > > > > >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 19:42:48, Konstantin Khlebnikov wrote: > On 01.11.2018 15:55, Michal Hocko wrote: > > On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: > > > > > > > > > On 01.11.2018 13:24, Michal Hocko wrote: > > > > On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > > > > >

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
On 01.11.2018 15:55, Michal Hocko wrote: On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: On 01.11.2018 13:24, Michal Hocko wrote: On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
On 01.11.2018 15:55, Michal Hocko wrote: On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: On 01.11.2018 13:24, Michal Hocko wrote: On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: > > > On 01.11.2018 13:24, Michal Hocko wrote: > > On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > > > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > > > I would go on and say that allocations with sizes too

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 13:48:17, Konstantin Khlebnikov wrote: > > > On 01.11.2018 13:24, Michal Hocko wrote: > > On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > > > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. > > > > I would go on and say that allocations with sizes too

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
On 01.11.2018 13:24, Michal Hocko wrote: On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that allocations with sizes too large can actually trigger a warning (once you have posted in the

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
On 01.11.2018 13:24, Michal Hocko wrote: On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that allocations with sizes too large can actually trigger a warning (once you have posted in the

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that allocations with sizes too large can actually trigger a warning (once you have posted in the previous version outside of the changelog area)

Re: [PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Michal Hocko
On Thu 01-11-18 13:09:16, Konstantin Khlebnikov wrote: > Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. I would go on and say that allocations with sizes too large can actually trigger a warning (once you have posted in the previous version outside of the changelog area)

[PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. Signed-off-by: Konstantin Khlebnikov --- mm/util.c |4 1 file changed, 4 insertions(+) diff --git a/mm/util.c b/mm/util.c index 8bf08b5b5760..f5f04fa22814 100644 --- a/mm/util.c +++ b/mm/util.c @@ -392,6 +392,9 @@ void

[PATCH 2] mm/kvmalloc: do not call kmalloc for size > KMALLOC_MAX_SIZE

2018-11-01 Thread Konstantin Khlebnikov
Allocations over KMALLOC_MAX_SIZE could be served only by vmalloc. Signed-off-by: Konstantin Khlebnikov --- mm/util.c |4 1 file changed, 4 insertions(+) diff --git a/mm/util.c b/mm/util.c index 8bf08b5b5760..f5f04fa22814 100644 --- a/mm/util.c +++ b/mm/util.c @@ -392,6 +392,9 @@ void