Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Christian Ehrhardt
On Thu, Sep 14, 2000 at 07:05:20PM +0200, Juan J. Quintela wrote: [ Removed linus from cc, he probably knows this ] > > "bill" == Bill Wendling <[EMAIL PROTECTED]> writes: > Linus, please don't apply. > bill> - The `head = >pages;' statement is useless inside the

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
Also sprach Juan J. Quintela: } > "bill" == Bill Wendling <[EMAIL PROTECTED]> writes: } } Hi } } Linus, please don't apply. } } bill> - The `head = >pages;' statement is useless inside the } bill> repeat, since head isn't modified inside the loop. } } No, but we

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Juan J. Quintela
> "bill" == Bill Wendling <[EMAIL PROTECTED]> writes: Hi Linus, please don't apply. bill> - The `head = >pages;' statement is useless inside the bill> repeat, since head isn't modified inside the loop. No, but we sleep inside the loop, and while we sleep, we don't have

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
Also sprach David Mansfield: } Bill Wendling wrote: } > } > Hi Linus, } > } > Here's a small optimization for the mm/filemap.c file. } > } > - The `head = >pages;' statement is useless inside the } > repeat, since head isn't modified inside the loop. } > - The `curr =

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread David Mansfield
Bill Wendling wrote: > > Hi Linus, > > Here's a small optimization for the mm/filemap.c file. > > - The `head = >pages;' statement is useless inside the > repeat, since head isn't modified inside the loop. > - The `curr = curr->next;' statement doesn't need to be

[PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Bill Wendling
Hi Linus, Here's a small optimization for the mm/filemap.c file. - The `head = >pages;' statement is useless inside the repeat, since head isn't modified inside the loop. - The `curr = curr->next;' statement doesn't need to be executed if the repeat is taken.

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread David Mansfield
Bill Wendling wrote: Hi Linus, Here's a small optimization for the mm/filemap.c file. - The `head = mapping-pages;' statement is useless inside the repeat, since head isn't modified inside the loop. - The `curr = curr-next;' statement doesn't need to be

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Juan J. Quintela
"bill" == Bill Wendling [EMAIL PROTECTED] writes: Hi Linus, please don't apply. bill - The `head = mapping-pages;' statement is useless inside the bill repeat, since head isn't modified inside the loop. No, but we sleep inside the loop, and while we sleep, we don't have locked

Re: [PATCH 2.4.0-test8] mm/filemap.c

2000-09-14 Thread Christian Ehrhardt
On Thu, Sep 14, 2000 at 07:05:20PM +0200, Juan J. Quintela wrote: [ Removed linus from cc, he probably knows this ] "bill" == Bill Wendling [EMAIL PROTECTED] writes: Linus, please don't apply. bill - The `head = mapping-pages;' statement is useless inside the