Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-02 Thread Takashi Iwai
At Tue, 01 Feb 2005 17:15:56 +, Paulo Marques wrote: > > [1 ] > Takashi Iwai wrote: > > [...] > > > > Thanks, that looks almost fine except: > > > > > >>diff -uprN -X dontdiff vanilla-2.6.11-rc2-bk9/sound/core/sound.c > >>linux-2.6.11-rc2-bk9/sound/core/sound.c > >>---

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-02 Thread Takashi Iwai
At Tue, 01 Feb 2005 17:15:56 +, Paulo Marques wrote: [1 text/plain; us-ascii (7bit)] Takashi Iwai wrote: [...] Thanks, that looks almost fine except: diff -uprN -X dontdiff vanilla-2.6.11-rc2-bk9/sound/core/sound.c linux-2.6.11-rc2-bk9/sound/core/sound.c ---

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: [...] Thanks, that looks almost fine except: diff -uprN -X dontdiff vanilla-2.6.11-rc2-bk9/sound/core/sound.c linux-2.6.11-rc2-bk9/sound/core/sound.c --- vanilla-2.6.11-rc2-bk9/sound/core/sound.c 2005-01-31 20:05:34.0 + +++

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 15:39:25 +, Paulo Marques wrote: > > [1 ] > Takashi Iwai wrote: > > At Tue, 01 Feb 2005 13:07:25 +, > > Paulo Marques wrote: > > > >>I thought of going all the way and changing the callers of kstrdup in > >>sound to use kfree, so that it would work without debugging

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: At Tue, 01 Feb 2005 13:07:25 +, Paulo Marques wrote: I thought of going all the way and changing the callers of kstrdup in sound to use kfree, so that it would work without debugging memory allocated for strdup'ed strings. However the code there already uses kfree, just

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 13:07:25 +, Paulo Marques wrote: > > I thought of going all the way and changing the callers of kstrdup in > sound to use kfree, so that it would work without debugging memory > allocated for strdup'ed strings. > > However the code there already uses kfree, just not the

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: [...] The compile should be fine but it may result in memory corruption since kmalloc/kfree become wrappers when CONFIG_SND_DEBUG_MEMORY is set. See include/sound/core.h. Ok, I see what you mean. I'm sorry I've missed this, but you must admit that code like this: #define

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 12:27:44 +, Paulo Marques wrote: > > Takashi Iwai wrote: > > At Tue, 1 Feb 2005 03:28:46 +, > > "" <[EMAIL PROTECTED]> wrote: > > > >>[1 ] > >> > >>This patch removes the strdup implementation from the sound core > >>(snd_kmalloc_strdup), and updates it to use the

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: At Tue, 1 Feb 2005 03:28:46 +, "" <[EMAIL PROTECTED]> wrote: [1 ] This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and updates it to use the kstrdup library function. Signed-off-by: Paulo Marques <[EMAIL PROTECTED]> This patch won't

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 1 Feb 2005 03:28:46 +, "" <[EMAIL PROTECTED]> wrote: > > [1 ] > > This patch removes the strdup implementation from the sound core > (snd_kmalloc_strdup), and updates it to use the kstrdup library function. > > Signed-off-by: Paulo Marques <[EMAIL PROTECTED]> This patch won't

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 1 Feb 2005 03:28:46 +, [EMAIL PROTECTED] wrote: [1 text/plain; iso-8859-1 (quoted-printable)] This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and updates it to use the kstrdup library function. Signed-off-by: Paulo Marques [EMAIL

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: At Tue, 1 Feb 2005 03:28:46 +, [EMAIL PROTECTED] wrote: [1 text/plain; iso-8859-1 (quoted-printable)] This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and updates it to use the kstrdup library function. Signed-off-by: Paulo Marques

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 12:27:44 +, Paulo Marques wrote: Takashi Iwai wrote: At Tue, 1 Feb 2005 03:28:46 +, [EMAIL PROTECTED] wrote: [1 text/plain; iso-8859-1 (quoted-printable)] This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: [...] The compile should be fine but it may result in memory corruption since kmalloc/kfree become wrappers when CONFIG_SND_DEBUG_MEMORY is set. See include/sound/core.h. Ok, I see what you mean. I'm sorry I've missed this, but you must admit that code like this: #define

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 13:07:25 +, Paulo Marques wrote: I thought of going all the way and changing the callers of kstrdup in sound to use kfree, so that it would work without debugging memory allocated for strdup'ed strings. However the code there already uses kfree, just not the

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: At Tue, 01 Feb 2005 13:07:25 +, Paulo Marques wrote: I thought of going all the way and changing the callers of kstrdup in sound to use kfree, so that it would work without debugging memory allocated for strdup'ed strings. However the code there already uses kfree, just

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Takashi Iwai
At Tue, 01 Feb 2005 15:39:25 +, Paulo Marques wrote: [1 text/plain; us-ascii (7bit)] Takashi Iwai wrote: At Tue, 01 Feb 2005 13:07:25 +, Paulo Marques wrote: I thought of going all the way and changing the callers of kstrdup in sound to use kfree, so that it would work

Re: [PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-02-01 Thread Paulo Marques
Takashi Iwai wrote: [...] Thanks, that looks almost fine except: diff -uprN -X dontdiff vanilla-2.6.11-rc2-bk9/sound/core/sound.c linux-2.6.11-rc2-bk9/sound/core/sound.c --- vanilla-2.6.11-rc2-bk9/sound/core/sound.c 2005-01-31 20:05:34.0 + +++

[PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-01-31 Thread
This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and updates it to use the kstrdup library function. Signed-off-by: Paulo Marques <[EMAIL PROTECTED]> -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do

[PATCH 2.6] 7/7 replace snd_kmalloc_strdup by kstrdup

2005-01-31 Thread
This patch removes the strdup implementation from the sound core (snd_kmalloc_strdup), and updates it to use the kstrdup library function. Signed-off-by: Paulo Marques [EMAIL PROTECTED] -- Paulo Marques - www.grupopie.com All that is necessary for the triumph of evil is that good men do