Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-10 Thread Ronald S. Bultje
Hi Jean, On Thu, 10 Mar 2005, Jean Delvare wrote: > > My experience is not the same as yours, it seems... I cannot explain why, > > unfortunately. (...) > > I can. [..] > So as long as you don't move to a 2.6.11 kernel, don't even bother > trying my patches, because you will never hit the code tha

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-10 Thread Jean Delvare
Hi Ronald, > I indeed don't test RC/MM kernels. I'm fairly happy with the current > driver status, so I'm not doing any active new development on it. I run > standard Fedora kernels with CVS of the driver (which is the same as > what's in 2.6.10). > (...) > My experience is not the same as yours,

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-10 Thread Ronald S. Bultje
Hi Jean, thanks for the reply. On Thu, 10 Mar 2005, Jean Delvare wrote: > I'm glad to learn you are testing things. Still the oops in saa7110 went > unnoticed for the past 3 months, so I guess that either you don't have > a DC10(+) in your test panel, or you did not test mm/rc kernels. I indeed

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-10 Thread Jean Delvare
Hi Ronald, [Jean Delvare] > It is possible that people are able to get their board to still work > without my patch, if the chips were properly configured in the first > place and they don't attempt to reconfigure them (like norm change). I > don't know the chips well enough to tell how probable

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-10 Thread Ronald S. Bultje
Hi Jean, I'm sorry for a late reply, mail is (still) misbehaving. I hope this arrives at all... On Wed, 9 Mar 2005, Jean Delvare wrote: > It is possible that people are able to get their board to still work > without my patch, if the chips were properly configured in the first > place and they do

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-09 Thread Chris Wright
* Jean Delvare ([EMAIL PROTECTED]) wrote: > > > > Are people reporting this as a problem? > > Not that I know. For adv7175 it couldn't be reported so far anyway > because people would hit the oops in saa7110 before (same board: DC10+, > oops fixed in a different patch). Heh, right. > It is poss

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-09 Thread Jean Delvare
Hi Chris, > > While working on the saa7110 driver I found a problem with the way > > various video drivers (found on Zoran-based boards) prepare i2c > > messages to be used by i2c_transfer. The drivers improperly copy the > > i2c client flags as the message flags, while both sets are mostly > > un

Re: [PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-09 Thread Chris Wright
* Jean Delvare ([EMAIL PROTECTED]) wrote: > Hi all, > > While working on the saa7110 driver I found a problem with the way > various video drivers (found on Zoran-based boards) prepare i2c messages > to be used by i2c_transfer. The drivers improperly copy the i2c client > flags as the message flag

[PATCH 2.6] Fix i2c messsage flags in video drivers

2005-03-08 Thread Jean Delvare
Hi all, While working on the saa7110 driver I found a problem with the way various video drivers (found on Zoran-based boards) prepare i2c messages to be used by i2c_transfer. The drivers improperly copy the i2c client flags as the message flags, while both sets are mostly unrelated. The net effec