On Sun, Feb 06, 2005 at 09:26:41PM +0100, Aur?lien Jarno wrote:
> Hi Greg,
>
> Please find below the new version of the patch against kernel
> 2.6.11-rc3-mm1 to add the sis5595 driver (sensor part).
>
> As you suggested, I have changed the PCI part of the driver, taking the
> via686a driver as an
Hi Greg,
Please find below the new version of the patch against kernel
2.6.11-rc3-mm1 to add the sis5595 driver (sensor part).
As you suggested, I have changed the PCI part of the driver, taking the
via686a driver as an example. I have also changed the comparison of
jiffies by using time_after.
Hi Greg & all,
> > +/* Locate SiS bridge and correct base address for SIS5595 */
> > +static int sis5595_find_sis(int *address)
> > +{
> > + u16 val;
> > + int *i;
> > +
> > + if (!(s_bridge =
> > + pci_get_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_SI_503, NULL)))
> > + return
On Tue, Feb 01, 2005 at 01:14:14PM +0100, Aurelien Jarno wrote:
> + if(force_addr)
Please put a space after the "if" and before the "(". You do this in a
number of places.
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
On Tue, Feb 01, 2005 at 01:14:14PM +0100, Aurelien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> + u16 val;
> + int *i;
> +
> + if (!(s_bridge =
> + pci_get_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID_
Hi Alexey,
> lm90 (all sensors chips have approximately the same speed, right?) spec
> says:
Absolutely not, it depends on the raw speed (internal clock) and the
number of channels. But in fact it doesn't matter, see below.
> "It takes the LM90 31.25 ms to measure the temperature of the remote
On Tuesday 01 February 2005 15:52, Jean Delvare wrote:
> > What about making sis5595_update_device() a simple jiffies-related wrapper
> > around function that updates "struct sis5595" unconditionally. I'm not sure
> > I plugged sis5595_do_update_client right, but you'll get the idea.
> 1* It forc
Quoting myself:
> To me, the only acceptable simplification is
> the initialization of "last_updated" to something which ensures that
> the first update attempt will succeed - providing we actually can do
> that.
On second thought, we obviously cannot, because jiffies wrap, so there is
no single
Hi Alexey,
> What about making sis5595_update_device() a simple jiffies-related wrapper
> around function that updates "struct sis5595" unconditionally. I'm not sure
> I plugged sis5595_do_update_client right, but you'll get the idea.
Yeah I get the idea, I think I had something similar in mind
On Tuesday 01 February 2005 13:49, Jean Delvare wrote:
> > Maybe you should call sis5595_update_device() in initialization function
> > and get rid of "value" field. It's sole purpose to fill "struct sis5595"
> > when it's known that "last_updated" field contains crap.
> Doesn't work. If you disc
On Tue, Feb 01, 2005 at 02:20:17PM +0200, Alexey Dobriyan wrote:
> > + dev_err(&s_bridge->dev, "sis5595.ko: Error: Looked for
> > SIS5595 but found unsupported device %.4X\n", *i);
>
> > + dev_err(&s_bridge->dev, "sis5595.ko: base address not set -
> > upgrade BIOS or
Hi Alexey,
> Maybe you should call sis5595_update_device() in initialization function
> and get rid of "value" field. It's sole purpose to fill "struct sis5595"
> when it's known that "last_updated" field contains crap.
I assume you meant "valid" field.
Doesn't work. If you discard the "valid"
On Tue, 1 Feb 2005 11:11:35 +0100, Aurelien Jarno wrote:
> Please find below the new version of the patch against kernel
> 2.6.11-rc2-mm2 to add the sis5595 driver (sensor part).
> --- linux-2.6.11-rc2-mm2.orig/drivers/i2c/chips/sis5595.c
> +++ linux-2.6.11-rc2-mm2/drivers/i2c/chips/sis5595.c
>
Hi Greg,
Please find below the new version of the patch against kernel
2.6.11-rc2-mm2 to add the sis5595 driver (sensor part).
As you suggested, I have changed pci_find_device by pci_get_device, and
replaced the printk() by dev_err(). I have also sorted the blacklist so
that the PCI devices ar
On Tue, Jan 25, 2005 at 11:09:45PM +0100, Aur?lien Jarno wrote:
> +/* Locate SiS bridge and correct base address for SIS5595 */
> +static int sis5595_find_sis(int *address)
> +{
> + u16 val;
> + int *i;
> +
> + if (!(s_bridge =
> + pci_find_device(PCI_VENDOR_ID_SI, PCI_DEVICE_ID
Hi Greg,
The following patch against kernel 2.6.11-rc2-mm1 adds the sis5595
driver (sensor part). I have ported it from the 2.4 version
It has been reviewed by Jean Delvare, partly on IRC.
Please apply.
Thanks,
Aurelien
Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]>
diff -urN linux-2.6.11-
16 matches
Mail list logo
