On Sat, Jan 29, 2005 at 09:08:55PM -0500, Shawn Starr wrote:
> Description: Cleanup some cluttered macros, add error checking for fan
> divisor value set.
>
> Signed-off-by: Sytse Wielinga <[EMAIL PROTECTED]>
> Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]>
> Signed-off-by: Shawn Starr <[EMAIL
Description: Cleanup some cluttered macros, add error checking for fan divisor
value set.
Signed-off-by: Sytse Wielinga <[EMAIL PROTECTED]>
Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]>
Signed-off-by: Shawn Starr <[EMAIL PROTECTED]>
Description: Cleanup some cluttered macros, add error chec
On Thu, Jan 27, 2005 at 11:56:46AM -0500, Shawn Starr wrote:
> Description: Cleanup some cluttered macros, add error
> checking for fan divisor value set.
Hm, we'll get there yet. Your patch was not in a plain text form, so
that I could apply it directly from the email.
> Approved-by: Greg KH <[
Description: Cleanup some cluttered macros, add error
checking for fan divisor value set.
Approved-by: Greg KH <[EMAIL PROTECTED]>
Signed-off-by: Sytse Wielinga
<[EMAIL PROTECTED]>
Signed-off-by: Aurelien Jarno <[EMAIL PROTECTED]>
Signed-off-by: Shawn Starr <[EMAIL PROTECTED]>
--- Greg KH <[EMAI
On Wed, Jan 26, 2005 at 12:31:30PM -0500, Shawn Starr wrote:
> Here is the corrected fix, yeah that didn't make
> sense.
> 3AM isn't a good time to send patches I guess :-)
Care to resend it, with a full description and a Signed-off-by: line so
I can apply it?
thanks,
greg k-h
-
To unsubscrib
Here is the corrected fix, yeah that didn't make
sense.
3AM isn't a good time to send patches I guess :-)
--- Greg KH <[EMAIL PROTECTED]> wrote:
> On Wed, Jan 26, 2005 at 02:57:35AM -0500, Shawn
> Starr wrote:
> > static inline unsigned char FAN_TO_REG(unsigned
> rpm, unsigned div)
> > {
>
Greg KH wrote:
On Wed, Jan 26, 2005 at 02:57:35AM -0500, Shawn Starr wrote:
static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
{
- if (rpm == 0)
+ if (rpm <= 0)
As was pointed out, this doesn't make any sense.
Care to redo the patch?
Please note that the problem is not
On Wed, Jan 26, 2005 at 02:57:35AM -0500, Shawn Starr wrote:
> static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
> {
> - if (rpm == 0)
> + if (rpm <= 0)
As was pointed out, this doesn't make any sense.
Care to redo the patch?
thanks,
greg k-h
-
To unsubscribe from thi
On Wed, Jan 26, 2005 at 03:05:09PM +0100, I wrote:
> BTW, can anyone tell me why the uints in this parameter list are declared as
> 'unsigned' and not as 'unsigned int'?
$ find /usr/src/linux/ -name \*.c |xargs grep unsigned\ [^icsl] |wc -l
3151
- Gives himself a good smack on the head -
Sorry ab
On Wed, Jan 26, 2005 at 02:49:23AM -0500, Shawn Starr wrote:
> static inline unsigned char FAN_TO_REG(unsigned rpm, unsigned div)
> {
> - if (rpm == 0)
> + if (rpm <= 0)
The rpm parameter is unsigned so this change is useless. The rest makes sense
to me.
BTW, can anyone tell me why the uints in
You know, after seeing that patch, that it just makes sense to add some of
those cleanups to the lm80 driver.
Shawn.
lm80-i2c-0-28
Adapter: SMBus PIIX4 adapter at fe00
+5V: +4.90 V (min = +4.74 V, max = +5.25 V)
VTT: +1.72 V (min = +1.70 V, max = +2.10 V)
+3.3V: +3.35 V (mi
You know, after seeing that patch, that it just makes sense to add some of
those cleanups to the lm80 driver.
Shawn.
lm80-i2c-0-28
Adapter: SMBus PIIX4 adapter at fe00
+5V: +4.90 V (min = +4.74 V, max = +5.25 V)
VTT: +1.72 V (min = +1.70 V, max = +2.10 V)
+3.3V: +3.35 V (
12 matches
Mail list logo
