Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Mar 2005 01:49:52 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, Bartlomiej. > > On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > > > Taskfile DMA path is still broken.

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 02 Mar 2005 00:56:18 -0500, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Bartlomiej Zolnierkiewicz wrote: > > If somebody implements SG_IO ioctl and SCSI command pass-through > > from libata for IDE driver (and add possibility for discrete taskfiles), we > > can > > just deprecate

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 02 Mar 2005 00:56:18 -0500, Jeff Garzik [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: If somebody implements SG_IO ioctl and SCSI command pass-through from libata for IDE driver (and add possibility for discrete taskfiles), we can just deprecate HDIO_DRIVE_TASKFILE,

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-02 Thread Bartlomiej Zolnierkiewicz
On Wed, 2 Mar 2005 01:49:52 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Hello, Bartlomiej. On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Taskfile DMA path is still broken. Also calling

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: If somebody implements SG_IO ioctl and SCSI command pass-through from libata for IDE driver (and add possibility for discrete taskfiles), we can just deprecate HDIO_DRIVE_TASKFILE, forget about it and some time later remove this FPOS. Can you explain what you mean

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Tejun Heo
Hello, Bartlomiej. On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > Taskfile DMA path is still broken. Also calling ide_end_request() > > will work there, but IMHO it's just cleaner to

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Bartlomiej Zolnierkiewicz
On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo <[EMAIL PROTECTED]> wrote: > On Thu, Feb 24, 2005 at 04:58:03PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <[EMAIL PROTECTED]> > > wrote: > > > > > > 01_ide_task_end_request_fix.patch > > > > > >

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Bartlomiej Zolnierkiewicz
On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo [EMAIL PROTECTED] wrote: On Thu, Feb 24, 2005 at 04:58:03PM +0100, Bartlomiej Zolnierkiewicz wrote: On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 01_ide_task_end_request_fix.patch

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Tejun Heo
Hello, Bartlomiej. On Tue, Mar 01, 2005 at 03:30:32PM +0100, Bartlomiej Zolnierkiewicz wrote: On Sun, 27 Feb 2005 15:49:22 +0900, Tejun Heo [EMAIL PROTECTED] wrote: Taskfile DMA path is still broken. Also calling ide_end_request() will work there, but IMHO it's just cleaner to finish

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-03-01 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: If somebody implements SG_IO ioctl and SCSI command pass-through from libata for IDE driver (and add possibility for discrete taskfiles), we can just deprecate HDIO_DRIVE_TASKFILE, forget about it and some time later remove this FPOS. Can you explain what you mean

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-26 Thread Tejun Heo
On Thu, Feb 24, 2005 at 04:58:03PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <[EMAIL PROTECTED]> wrote: > > > > 01_ide_task_end_request_fix.patch > > > > task_end_request() modified to always call ide_end_drive_cmd() > > for

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-26 Thread Tejun Heo
On Thu, Feb 24, 2005 at 04:58:03PM +0100, Bartlomiej Zolnierkiewicz wrote: On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 01_ide_task_end_request_fix.patch task_end_request() modified to always call ide_end_drive_cmd() for taskfile

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-24 Thread Bartlomiej Zolnierkiewicz
On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo <[EMAIL PROTECTED]> wrote: > > 01_ide_task_end_request_fix.patch > > task_end_request() modified to always call ide_end_drive_cmd() > for taskfile requests. Previously, ide_end_drive_cmd() was > called only when

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-24 Thread Bartlomiej Zolnierkiewicz
On Thu, 10 Feb 2005 17:38:14 +0900 (KST), Tejun Heo [EMAIL PROTECTED] wrote: 01_ide_task_end_request_fix.patch task_end_request() modified to always call ide_end_drive_cmd() for taskfile requests. Previously, ide_end_drive_cmd() was called only when

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-10 Thread Tejun Heo
01_ide_task_end_request_fix.patch task_end_request() modified to always call ide_end_drive_cmd() for taskfile requests. Previously, ide_end_drive_cmd() was called only when task->tf_out_flags.all was set. Also, ide_dma_intr() is modified to use

Re: [PATCH 2.6.11-rc3 01/11] ide: task_end_request() fix

2005-02-10 Thread Tejun Heo
01_ide_task_end_request_fix.patch task_end_request() modified to always call ide_end_drive_cmd() for taskfile requests. Previously, ide_end_drive_cmd() was called only when task-tf_out_flags.all was set. Also, ide_dma_intr() is modified to use