Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-08-11 Thread Jeff Garzik
Grant Coady wrote: For: linux-2.6.13-rc4: 118 pci_ids-defined_elsewhere-files 475 pci_ids-defined_elsewhere-items 7 pci_ids-duplicate-items 2321 pci_ids-list 725 pci_ids-not_used linux-2.6.13-rc3-mm3: 119 pci_ids-defined_elsewhere-files 475 pci_ids-defined_elsewhere-items 7

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-08-11 Thread Jeff Garzik
Grant Coady wrote: Does roughly 1/3 unused: 63065 2005-07-30 14:51 pci_ids-list 19243 2005-07-30 14:52 pci_ids-not_used Seem in ballpark? Yes. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-08-11 Thread Jeff Garzik
Grant Coady wrote: For: linux-2.6.13-rc4: 118 pci_ids-defined_elsewhere-files 475 pci_ids-defined_elsewhere-items 7 pci_ids-duplicate-items 2321 pci_ids-list 725 pci_ids-not_used linux-2.6.13-rc3-mm3: 119 pci_ids-defined_elsewhere-files 475 pci_ids-defined_elsewhere-items 7

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-08-11 Thread Jeff Garzik
Grant Coady wrote: Does roughly 1/3 unused: 63065 2005-07-30 14:51 pci_ids-list 19243 2005-07-30 14:52 pci_ids-not_used Seem in ballpark? Yes. Jeff - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-30 Thread Grant Coady
On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >[speaking to the audience] I wouldn't mind if someone did a pass >through pci_ids.h and removed all the constants that are not being used. > If constants are not being used, it's IMHO more appropriate to store >that

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-30 Thread Grant Coady
On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Grant Coady
On Fri, 29 Jul 2005 23:52:39 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >However you did your search, you did it wrong. The very first two >entries I tried had zero uses: > >[EMAIL PROTECTED] linux-2.6]$ grepsrc ICH7_22 >./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_22 0x27e0

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Grant Coady wrote: On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. Only these seem not referenced by source:

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Grant Coady
On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >[speaking to the audience] I wouldn't mind if someone did a pass >through pci_ids.h and removed all the constants that are not being used. Only these seem not referenced by source: PCI_CLASS_SYSTEM_PCI_HOTPLUG

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik <[EMAIL PROTECTED]> wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info in pci.ids.

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Andrew Morton
Jeff Garzik <[EMAIL PROTECTED]> wrote: > > [speaking to the audience] I wouldn't mind if someone did a pass > through pci_ids.h and removed all the constants that are not being used. > If constants are not being used, it's IMHO more appropriate to store > that info in pci.ids. It looks like

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Gaston, Jason D wrote: This define is not actually used anywhere that I know of. I just wanted to be consistent and correct, following what was previously done. I have been wondering if I should be adding devices to the pci_ids.h file that are not being currently used. It seems like most

RE: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Gaston, Jason D
>Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org >Subject: Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R > >Jason Gaston wrote: >> Hello, >> >> This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. >This

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Jason Gaston wrote: Hello, This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. This patch was built against the 2.6.13-rc4 kernel. If acceptable, please apply. Thanks, Jason Gaston Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> ---

[PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jason Gaston
Hello, This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file.  This patch was built against the 2.6.13-rc4 kernel.   If acceptable, please apply. Thanks, Jason Gaston Signed-off-by:  Jason Gaston <[EMAIL PROTECTED]> --- linux-2.6.13-rc4/include/linux/pci_ids.h.orig

[PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jason Gaston
Hello, This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file.  This patch was built against the 2.6.13-rc4 kernel.   If acceptable, please apply. Thanks, Jason Gaston Signed-off-by:  Jason Gaston [EMAIL PROTECTED] --- linux-2.6.13-rc4/include/linux/pci_ids.h.orig

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Jason Gaston wrote: Hello, This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. This patch was built against the 2.6.13-rc4 kernel. If acceptable, please apply. Thanks, Jason Gaston Signed-off-by: Jason Gaston [EMAIL PROTECTED] ---

RE: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Gaston, Jason D
PROTECTED]; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R Jason Gaston wrote: Hello, This patch adds the Intel ICH7R SATA RAID DID to the pci_ids.h file. This patch was built against the 2.6.13-rc4 kernel. If acceptable, please

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Gaston, Jason D wrote: This define is not actually used anywhere that I know of. I just wanted to be consistent and correct, following what was previously done. I have been wondering if I should be adding devices to the pci_ids.h file that are not being currently used. It seems like most

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Andrew Morton
Jeff Garzik [EMAIL PROTECTED] wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info in pci.ids. It looks like Greg

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Jeff Garzik
Andrew Morton wrote: Jeff Garzik [EMAIL PROTECTED] wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. If constants are not being used, it's IMHO more appropriate to store that info in pci.ids.

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Grant Coady
On Fri, 29 Jul 2005 18:21:05 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: [speaking to the audience] I wouldn't mind if someone did a pass through pci_ids.h and removed all the constants that are not being used. Only these seem not referenced by source: PCI_CLASS_SYSTEM_PCI_HOTPLUG

Re: [PATCH 2.6.13-rc4 1/1] pci_ids: patch for Intel ICH7R

2005-07-29 Thread Grant Coady
On Fri, 29 Jul 2005 23:52:39 -0400, Jeff Garzik [EMAIL PROTECTED] wrote: However you did your search, you did it wrong. The very first two entries I tried had zero uses: [EMAIL PROTECTED] linux-2.6]$ grepsrc ICH7_22 ./include/linux/pci_ids.h:#define PCI_DEVICE_ID_INTEL_ICH7_22 0x27e0 [EMAIL