Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Brett Russ
Greg KH wrote: Hmm, I did build it before submitting, saw not even a warning. So I just rebuilt it again to verify, and same thing. Why would my tree work and not yours? config file? You don't have MSI enabled in yours :( Yup, you're right. Sorry about that. The patch I sent @15:23 tod

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Greg KH
On Mon, Aug 15, 2005 at 03:08:47PM -0400, Brett Russ wrote: > Greg KH wrote: > >On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote: > > > >>Simple cleanup to eliminate X copies of the pci_enable_intx() function > >>in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout > >>lib

[PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Brett M Russ
Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> Index: linux-2.6.13-rc6/drivers/scsi/sata_sis.c

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Jeff Garzik
Greg KH wrote: On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote: Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> It would hav

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Brett Russ
Greg KH wrote: On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote: Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> It would hav

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Greg KH
On Fri, Aug 12, 2005 at 06:43:03PM -0400, Brett Russ wrote: > Simple cleanup to eliminate X copies of the pci_enable_intx() function > in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout > libata and msi.c. > > Signed-off-by: Brett Russ <[EMAIL PROTECTED]> It would have been nice

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-15 Thread Greg KH
On Fri, Aug 12, 2005 at 08:29:19PM -0400, Jeff Garzik wrote: > Brett Russ wrote: > >Simple cleanup to eliminate X copies of the pci_enable_intx() function > >in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout > >libata and msi.c. > > > >Signed-off-by: Brett Russ <[EMAIL PROTECTED]

Re: [PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-12 Thread Jeff Garzik
Brett Russ wrote: Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> Looks good to me. Greg, do you want to queue this (since it touches PCI

[PATCH 2.6.13-rc6] PCI/libata INTx cleanup

2005-08-12 Thread Brett Russ
Simple cleanup to eliminate X copies of the pci_enable_intx() function in libata. Moved ahci.c's pci_intx() to pci.c and use it throughout libata and msi.c. Signed-off-by: Brett Russ <[EMAIL PROTECTED]> Index: linux-2.6.13-rc6/drivers/scsi/sata_sis.c