Re: [PATCH 2.6.19.2] SCSI sd: udev accessing an uninitialized scsi_disk results in a crash

2007-02-02 Thread James Bottomley
On Fri, 2007-02-02 at 17:56 -0800, Greg KH wrote: > > Thanks - I'll queue this up for 2.6.20 also. > > No objection from me, as long as James says this is ok. > > I wonder why we haven't noticed this in the past? Because the race is so small ... I'll queue it in the rc-fixes tree .. I have thre

Re: [PATCH 2.6.19.2] SCSI sd: udev accessing an uninitialized scsi_disk results in a crash

2007-02-02 Thread Greg KH
On Fri, Feb 02, 2007 at 05:19:24PM -0800, Andrew Morton wrote: > On Fri, 2 Feb 2007 17:34:56 +0530 > Nagendra Singh Tomar <[EMAIL PROTECTED]> wrote: > > > Hi, > > sd_probe() calls class_device_add() even before initializing the > > sdkp->device variable. class_device_add() eventually results

Re: [PATCH 2.6.19.2] SCSI sd: udev accessing an uninitialized scsi_disk results in a crash

2007-02-02 Thread Andrew Morton
On Fri, 2 Feb 2007 17:34:56 +0530 Nagendra Singh Tomar <[EMAIL PROTECTED]> wrote: > Hi, > sd_probe() calls class_device_add() even before initializing the > sdkp->device variable. class_device_add() eventually results in the user mode > udev program to be called. udev program can read the

[PATCH 2.6.19.2] SCSI sd: udev accessing an uninitialized scsi_disk results in a crash

2007-02-02 Thread Nagendra Singh Tomar
Hi, sd_probe() calls class_device_add() even before initializing the sdkp->device variable. class_device_add() eventually results in the user mode udev program to be called. udev program can read the the allow_restart attribute of the newly created scsi device. This is resulting in a cra