Re: [PATCH 2.6.20-rc3] TTY_IO code cleanups

2007-01-06 Thread Jan Engelhardt
On Jan 5 2007 16:00, David Rientjes wrote: >> @@ -791,17 +790,15 @@ static int tty_ldisc_try(struct tty_struct *tty) >> { >> unsigned long flags; >> struct tty_ldisc *ld; >> -int ret = 0; >> >> spin_lock_irqsave(&tty_ldisc_lock, flags); >> ld = &tty->ldisc; >> -i

Re: [PATCH 2.6.20-rc3] TTY_IO code cleanups

2007-01-05 Thread Ahmed S. Darwish
> Signed-off-by: Ahmed Darwish <[EMAIL PROTECTED]> > struct tty_ldisc *ld; >- int ret = 0; > > spin_lock_irqsave(&tty_ldisc_lock, flags); > ld = &tty->ldisc; >- if(test_bit(TTY_LDISC, &tty->flags)) >- { >+ if(test_bit(TTY_LDISC, &tty->flags)) { >

Re: [PATCH 2.6.20-rc3] TTY_IO code cleanups

2007-01-05 Thread David Rientjes
On Sat, 6 Jan 2007, Ahmed S. Darwish wrote: > @@ -791,17 +790,15 @@ static int tty_ldisc_try(struct tty_struct *tty) > { > unsigned long flags; > struct tty_ldisc *ld; > - int ret = 0; > > spin_lock_irqsave(&tty_ldisc_lock, flags); > ld = &tty->ldisc; > - if

[PATCH 2.6.20-rc3] TTY_IO code cleanups

2007-01-05 Thread Ahmed S. Darwish
Hi all, >From Alan: > if you can send me a patch for the tty_io/tty_ioctl code which > switches to kzalloc where it makes sense and removes un-needed casts I'll > review it and push the bits that look sane upstream. Cleanups to switch kmalloc->kzalloc and to remove little redundant code found (i