Re: [PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Jeff Garzik
Mikael Pettersson wrote: @@ -271,6 +272,11 @@ static int pdc_port_start(struct ata_por struct pdc_port_priv *pp; int rc; + /* fix up port flags and cable type for SATA+PATA chips */ + ap->flags |= hp->port_flags[ap->port_no]; + if (ap->flags & ATA_FLAG_SATA) +

Re: [PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Jeff Garzik
Mikael Pettersson wrote: This patch implements a simple way of setting up per-port flags on the SATA+PATA Promise TX2plus chips, which is a prerequisite for supporting the PATA port on those chips. It is based on the observation that ap->flags isn't really used until after ->port_start() has bee

[PATCH 2.6.20-rc4 1/2] sata_promise: TX2plus PATA support

2007-01-09 Thread Mikael Pettersson
This patch implements a simple way of setting up per-port flags on the SATA+PATA Promise TX2plus chips, which is a prerequisite for supporting the PATA port on those chips. It is based on the observation that ap->flags isn't really used until after ->port_start() has been invoked. So it places the