Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-23 Thread David Brownell
On Tuesday 23 January 2007 8:07 am, Atsushi Nemoto wrote: > On Tue, 23 Jan 2007 07:42:15 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > Indeed the check can be omitted. Should I send a new patch just > > > moving class_device_get() into "if (master->bus_num == bus_num)" > > > block? > > >

Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-23 Thread Atsushi Nemoto
On Tue, 23 Jan 2007 07:42:15 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > Indeed the check can be omitted. Should I send a new patch just > > moving class_device_get() into "if (master->bus_num == bus_num)" > > block? > > Yes, please. OK, here is. This patch uses spi_master_get() instea

Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-23 Thread David Brownell
On Monday 22 January 2007 5:10 pm, Atsushi Nemoto wrote: > On Mon, 22 Jan 2007 14:12:02 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > > Here is a revised version. The children list of spi_master_class > > > contains only spi_master class so we can just compare bus_num member > > > instead o

Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-22 Thread Atsushi Nemoto
On Mon, 22 Jan 2007 14:12:02 -0800, David Brownell <[EMAIL PROTECTED]> wrote: > > Here is a revised version. The children list of spi_master_class > > contains only spi_master class so we can just compare bus_num member > > instead of class_id string. > > Looks just a bit iffy ... though, thanks

Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-22 Thread David Brownell
On Sunday 21 January 2007 6:25 pm, Atsushi Nemoto wrote: > Here is a revised version. The children list of spi_master_class > contains only spi_master class so we can just compare bus_num member > instead of class_id string. Looks just a bit iffy ... though, thanks for helping to finally sort th

Re: [PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-21 Thread Atsushi Nemoto
On Thu, 18 Jan 2007 20:28:49 +0900 (JST), Atsushi Nemoto <[EMAIL PROTECTED]> wrote: > The commit was to fix spi_busnum_to_master(). Here is a patch fixes > this function in other way, just searching children list of > class_device. Here is a revised version. The children list of spi_master_clas

[PATCH 2.6.20-rc5] SPI: alternative fix for spi_busnum_to_master

2007-01-18 Thread Atsushi Nemoto
If a SPI master device exists, udev (udevtrigger) causes kernel crash, due to wrong kobj pointer in kobject_uevent_env(). This problem was not in 2.6.19. The backtrace (on MIPS) was: [<8024db6c>] kobject_uevent_env+0x54c/0x5e8 [<802a8264>] store_uevent+0x1c/0x3c (in drivers/class.c) [<801cb14c>]