Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-16 Thread John Rose
Hi- Sounds good. A couple of questions/comments: > I think it is not necessary to have a special entry/kobject for each logical > port. I suggest we use SET_NETDEV_DEV to create links to all ethernet devices > that represent each a logical port. This should be in sync with all other > ethernet

Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-16 Thread Jan-Bernd Themann
Hi, I agree with most points. Here the new design proposal: On Wednesday 14 February 2007 23:25, John Rose wrote: > Hi- > > A few high level comments, then some really insignificant ones. > > First, is there a reason why we shouldn't have a sysfs entry/kobject for > each logical port? How is i

Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-15 Thread John Rose
> Second, the probe and remove functions do not communicate whether an add > or remove was successful. Combine this with the lack of port > information in the adapter sysfs directory, and the userspace tool has > no way of verifying a dynamic add/remove. One way to communicate a return code is by

Re: [PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-14 Thread John Rose
Hi- A few high level comments, then some really insignificant ones. First, is there a reason why we shouldn't have a sysfs entry/kobject for each logical port? How is it possible to determine, from the adapter sysfs directory, the current number of ports for that adapter? A port sysfs directory

[PATCH 2.6.21-rc1] ehea: dynamic add / remove port

2007-02-14 Thread Jan-Bernd Themann
This patch enables dynamic adding / removing of ehea ports by DLPAR tool. Signed-off-by: Jan-Bernd Themann <[EMAIL PROTECTED]> --- diff -Nurp -X dontdiff linux-2.6.20/drivers/net/ehea/ehea.h patched_kernel/drivers/net/ehea/ehea.h --- linux-2.6.20/drivers/net/ehea/ehea.h2007-02-12 14:44: