Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-20 Thread Joachim Fenkes
John Rose <[EMAIL PROTECTED]> wrote on 20.02.2007 12:25:06: > > If the probe operation succeeds, the respective device will show up > > beneath > > /sys/bus/ibmebus/devices. > > This approach is not particularly synchronous. Take the case of an add > failure: how long would an application wait

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-20 Thread John Rose
> If the probe operation succeeds, the respective device will show up > beneath > /sys/bus/ibmebus/devices. This approach is not particularly synchronous. Take the case of an add failure: how long would an application wait before deciding that the new device is not going to appear? It might be

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-20 Thread John Rose
If the probe operation succeeds, the respective device will show up beneath /sys/bus/ibmebus/devices. This approach is not particularly synchronous. Take the case of an add failure: how long would an application wait before deciding that the new device is not going to appear? It might be

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-20 Thread Joachim Fenkes
John Rose [EMAIL PROTECTED] wrote on 20.02.2007 12:25:06: If the probe operation succeeds, the respective device will show up beneath /sys/bus/ibmebus/devices. This approach is not particularly synchronous. Take the case of an add failure: how long would an application wait before

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
Sylvain Munaut <[EMAIL PROTECTED]> wrote on 15.02.2007 15:11:42: > Mmmh, I posted a patch that added a common uevent interface for all > of_device based bus. And that kinda clash with this one. Oops, I was not aware of this. I had a look at your patch and yes, it's a nice and generic interface.

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
John Rose <[EMAIL PROTECTED]> wrote on 15.02.2007 14:57:37: > Looks good. Questions: how can the user space tools verify the success > of an add or remove? If the probe operation succeeds, the respective device will show up beneath /sys/bus/ibmebus/devices. > Also, will /sys/bus/ibmebus

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
John Rose [EMAIL PROTECTED] wrote on 15.02.2007 14:57:37: Looks good. Questions: how can the user space tools verify the success of an add or remove? If the probe operation succeeds, the respective device will show up beneath /sys/bus/ibmebus/devices. Also, will /sys/bus/ibmebus exist

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-16 Thread Joachim Fenkes
Sylvain Munaut [EMAIL PROTECTED] wrote on 15.02.2007 15:11:42: Mmmh, I posted a patch that added a common uevent interface for all of_device based bus. And that kinda clash with this one. Oops, I was not aware of this. I had a look at your patch and yes, it's a nice and generic interface. I

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Sylvain Munaut
Hoang-Nam Nguyen wrote: > Additionally, the uevent interface is now implemented in the driver. > Mmmh, I posted a patch that added a common uevent interface for all of_device based bus. And that kinda clash with this one. I think it's a much cleaner approach to make it as common as possible.

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread John Rose
Hi- Looks good. Questions: how can the user space tools verify the success of an add or remove? Also, will /sys/bus/ibmebus exist even if the system booted with no LHEA nodes? One more comment below. @@ -161,7 +161,9 @@ static void __devinit ibmebus_dev_releas static ssize_t

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Hoang-Nam Nguyen
This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT "ibm,loc-code" property) into the "probe" attribute will notify ebus of addition

[PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Hoang-Nam Nguyen
This patch will add two sysfs attributes to /sys/bus/ibmebus which can be used to notify the ebus driver of added / removed ebus devices in the OF device tree. Echoing the device's location code (as found in the OFDT ibm,loc-code property) into the probe attribute will notify ebus of addition of

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread John Rose
Hi- Looks good. Questions: how can the user space tools verify the success of an add or remove? Also, will /sys/bus/ibmebus exist even if the system booted with no LHEA nodes? One more comment below. @@ -161,7 +161,9 @@ static void __devinit ibmebus_dev_releas static ssize_t

Re: [PATCH 2.6.21-rc1] ibmebus: Support dynamic addition and removal of adapters

2007-02-15 Thread Sylvain Munaut
Hoang-Nam Nguyen wrote: Additionally, the uevent interface is now implemented in the driver. Mmmh, I posted a patch that added a common uevent interface for all of_device based bus. And that kinda clash with this one. I think it's a much cleaner approach to make it as common as possible. But