Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Tony Vroon
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Alan Cox wrote: > Gak. I'd rather it stayed out of ata_qc_issue() which is a critical path > for performance. Our command issu is already too heavy and not all > controllers have queueing to absorb that. How many controllers actually > need this hook

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Tejun Heo
Alan Cox wrote: On Mon, 19 Mar 2007 13:42:37 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: Tony Vroon wrote: This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) wi

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Mikael Pettersson
On Mon, 19 Mar 2007 12:46:16 +, Alan Cox wrote: > > > This duplicates the IDE core LED trigger in the libata core. > > > I plan to use this by allowing PMU LED control on G5 towers. My test > > > platform > > > is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) > > > controll

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-19 Thread Alan Cox
On Mon, 19 Mar 2007 13:42:37 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Tony Vroon wrote: > > This duplicates the IDE core LED trigger in the libata core. > > I plan to use this by allowing PMU LED control on G5 towers. My test > > platform > > is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) wit

Re: [PATCH 2.6.22] Add LED trigger to libata core

2007-03-18 Thread Tejun Heo
Tony Vroon wrote: > This duplicates the IDE core LED trigger in the libata core. > I plan to use this by allowing PMU LED control on G5 towers. My test platform > is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. I think this fits better in libata-core.c::ata_qc_issue

[PATCH 2.6.22] Add LED trigger to libata core

2007-03-18 Thread Tony Vroon
This duplicates the IDE core LED trigger in the libata core. I plan to use this by allowing PMU LED control on G5 towers. My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. Signed-off-by: Tony Vroon <[EMAIL PROTECTED]> --- linux-2.6/drivers/ata/libata