Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pierre Peiffer
Pavel Emelyanov wrote: > Well I think you're right. The structure gains 50% in size... Really too > much to fight for performance in IPC :) > > Thanks for checking this thing. > > You may put my Acked-by in the original patch. > Cool. Thanks ! P. > Thanks, > Pavel > -- Pierre Peiffer - To

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pavel Emelyanov
Pierre Peiffer wrote: > Ok, I have the patch ready, but before sending it, I worry about the size of > struct ipc_namespace if we mark struct ipc_ids as ___cacheline_aligned > > Of course, you we fall into a classical match: performance vs memory size. > > As I don't think that I have the kno

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pierre Peiffer
Ok, I have the patch ready, but before sending it, I worry about the size of struct ipc_namespace if we mark struct ipc_ids as ___cacheline_aligned Of course, you we fall into a classical match: performance vs memory size. As I don't think that I have the knowledge to decide what we must focu

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pavel Emelyanov
Pierre Peiffer wrote: > Hi, > > Thanks for reviewing this ! > > Pavel Emelyanov wrote: >> Pavel Emelyanov wrote: >>> Cedric Le Goater wrote: Pierre Peiffer wrote: >> [snip] >> Pavel, what do you think of it ? >>> Looks sane, good catch, Pierre. >>> >>> But I'd find out whether th

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pierre Peiffer
Hi, Thanks for reviewing this ! Pavel Emelyanov wrote: > Pavel Emelyanov wrote: >> Cedric Le Goater wrote: >>> Pierre Peiffer wrote: > > [snip] > >>> Pavel, what do you think of it ? >> Looks sane, good catch, Pierre. >> >> But I'd find out whether these three ipc_ids intersect any >>

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-23 Thread Pavel Emelyanov
Pavel Emelyanov wrote: > Cedric Le Goater wrote: >> Pierre Peiffer wrote: [snip] >> Pavel, what do you think of it ? > > Looks sane, good catch, Pierre. > > But I'd find out whether these three ipc_ids intersect any > cache-line. In other words I'd mark the struct ipc_ids as > cacheline_a

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-22 Thread Pavel Emelyanov
Cedric Le Goater wrote: > Pierre Peiffer wrote: >> Each ipc_namespace contains a table of 3 pointers to struct ipc_ids (3 for >> msg, sem and shm, structure used to store all ipcs) >> These 'struct ipc_ids' are dynamically allocated for each icp_namespace as >> the ipc_namespace itself (for the ini

Re: [PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-22 Thread Cedric Le Goater
Pierre Peiffer wrote: > > Each ipc_namespace contains a table of 3 pointers to struct ipc_ids (3 for > msg, sem and shm, structure used to store all ipcs) > These 'struct ipc_ids' are dynamically allocated for each icp_namespace as > the ipc_namespace itself (for the init namespace, they are initi

[PATCH 2.6.24-rc3-mm1] IPC: make struct ipc_ids static in ipc_namespace

2007-11-22 Thread Pierre Peiffer
Each ipc_namespace contains a table of 3 pointers to struct ipc_ids (3 for msg, sem and shm, structure used to store all ipcs) These 'struct ipc_ids' are dynamically allocated for each icp_namespace as the ipc_namespace itself (for the init namespace, they are initialized with pointers to static