[PATCH 20/20] x86_64: Move cpu verification code to common file

2007-03-06 Thread Vivek Goyal
o This patch moves the code to verify long mode and SSE to a common file. This code is now shared by trampoline.S, wakeup.S, boot/setup.S and boot/compressed/head.S o So far we used to do very limited check in trampoline.S, wakeup.S and in 32bit entry point. Now all the entry paths are for

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Pavel Machek
Hi! > > > > > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) > > > > > > > > Normally it's not ok to take sole copyright on code that you mostly > > > > copied ... > > > > > > Is this a case where the original had no copyright notice? If so, > > > what do you suggest Vivek should

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Vivek Goyal
On Sat, Nov 18, 2006 at 11:58:14AM +0100, Andi Kleen wrote: > On Saturday 18 November 2006 11:55, Paul Mackerras wrote: > > Andi Kleen writes: > > > > > On Friday 17 November 2006 23:59, Vivek Goyal wrote: > > > > > > > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) > > > > > > No

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Andi Kleen
On Saturday 18 November 2006 11:55, Paul Mackerras wrote: > Andi Kleen writes: > > > On Friday 17 November 2006 23:59, Vivek Goyal wrote: > > > > > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) > > > > Normally it's not ok to take sole copyright on code that you mostly copie

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Paul Mackerras
Andi Kleen writes: > On Friday 17 November 2006 23:59, Vivek Goyal wrote: > > > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) > > Normally it's not ok to take sole copyright on code that you mostly copied ... Is this a case where the original had no copyright notice? If so, what

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Andi Kleen
On Friday 17 November 2006 23:59, Vivek Goyal wrote: > + * Copyright (c) 2006-2007 Vivek Goyal ([EMAIL PROTECTED]) Normally it's not ok to take sole copyright on code that you mostly copied ... -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread H. Peter Anvin
Andi Kleen wrote: Finding panic=.. would require writing a command line parser in 16bit assembly. I have my doubts that's a good use of anyone's time. There already is one, in the EDD code. -hpa - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-18 Thread Andi Kleen
> However, this test should probably be pushed earlier, into setup.S, > where executing a BIOS-clean reboot is much easier. It's already in there in fact. It wasn't originally, until we discovered that there is no way to output a message in head.S when you're using vesafb. The only way to give

reboot, not loop forever (Re: [PATCH 20/20] x86_64: Move CPU verification code to common file)

2006-11-18 Thread Oleg Verych
On Fri, Nov 17, 2006 at 11:32:59PM -0800, H. Peter Anvin wrote: > Oleg Verych wrote: > >On Fri, Nov 17, 2006 at 10:59:32PM -0800, H. Peter Anvin wrote: > >>Oleg Verych wrote: > >>>It will burn CPU, until power cycle will be done (my AMD64 laptop and > >>>Intel's amd64 destop PC require that). In ca

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread H. Peter Anvin
Oleg Verych wrote: On Fri, Nov 17, 2006 at 10:59:32PM -0800, H. Peter Anvin wrote: Oleg Verych wrote: It will burn CPU, until power cycle will be done (my AMD64 laptop and Intel's amd64 destop PC require that). In case of reboot timeout (or just reboot with jump to BIOS), i will just choose ano

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread Oleg Verych
On Fri, Nov 17, 2006 at 10:59:32PM -0800, H. Peter Anvin wrote: > Oleg Verych wrote: > > > >It will burn CPU, until power cycle will be done (my AMD64 laptop and > >Intel's amd64 destop PC require that). In case of reboot timeout (or > >just reboot with jump to BIOS), i will just choose another ima

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread H. Peter Anvin
Oleg Verych wrote: It will burn CPU, until power cycle will be done (my AMD64 laptop and Intel's amd64 destop PC require that). In case of reboot timeout (or just reboot with jump to BIOS), i will just choose another image to boot or will press F8 to have another boot device. That's a fairly

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread H. Peter Anvin
Andi Kleen wrote: May hang be done optional? There was a discussion about applying "panic" reboot timeout here. Is it possible to implement somehow? It would be tricky, but might be possible. But that would be a completely new feature -- the kernel has always hung in this case. If you think yo

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread Andi Kleen
> May hang be done optional? There was a discussion about applying > "panic" reboot timeout here. Is it possible to implement somehow? It would be tricky, but might be possible. But that would be a completely new feature -- the kernel has always hung in this case. If you think you need it submit

Re: [PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread Oleg Verych
Hallo. On 2006-11-17, Vivek Goyal wrote: [] > +no_longmode: > + /* This isn't an x86-64 CPU so hang */ > +1: > + hlt > + jmp 1b > + > +#include "../../kernel/verify_cpu.S" > + May hang be done optional? There was a discussion about applying "panic" reboot timeout here. Is it possi

[PATCH 20/20] x86_64: Move CPU verification code to common file

2006-11-17 Thread Vivek Goyal
o This patch moves the code to verify long mode and SSE to a common file. This code is not shared by trampoline.S, wakeup.S, boot/setup.S and boot/compressed/head.S o So far we used to do very limited check in trampoline.S, wakeup.S and in 32bit entry point. Now all the entry paths are for