Re: [PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2013-01-07 Thread Kent Overstreet
On Thu, Jan 03, 2013 at 03:25:12PM -0800, Andrew Morton wrote: > On Wed, 26 Dec 2012 17:59:59 -0800 > Kent Overstreet wrote: > > > struct { > > - struct mutexring_lock; > > + atomic_treqs_active; > > } cacheline_aligned; > > Is there a reason why this

Re: [PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2013-01-07 Thread Kent Overstreet
On Thu, Jan 03, 2013 at 03:25:12PM -0800, Andrew Morton wrote: On Wed, 26 Dec 2012 17:59:59 -0800 Kent Overstreet koverstr...@google.com wrote: struct { - struct mutexring_lock; + atomic_treqs_active; } cacheline_aligned; Is there a reason

Re: [PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2013-01-03 Thread Andrew Morton
On Wed, 26 Dec 2012 17:59:59 -0800 Kent Overstreet wrote: > struct { > - struct mutexring_lock; > + atomic_treqs_active; > } cacheline_aligned; Is there a reason why this guy remains aligned on CONFIG_SMP=n? -- To unsubscribe from this list:

Re: [PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2013-01-03 Thread Andrew Morton
On Wed, 26 Dec 2012 17:59:59 -0800 Kent Overstreet koverstr...@google.com wrote: struct { - struct mutexring_lock; + atomic_treqs_active; } cacheline_aligned; Is there a reason why this guy remains aligned on CONFIG_SMP=n? -- To

[PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2012-12-26 Thread Kent Overstreet
Signed-off-by: Kent Overstreet --- fs/aio.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 96fbd6b..fa87732 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -67,13 +67,6 @@ struct kioctx { unsigned long

[PATCH 20/32] aio: Give shared kioctx fields their own cachelines

2012-12-26 Thread Kent Overstreet
Signed-off-by: Kent Overstreet koverstr...@google.com --- fs/aio.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/fs/aio.c b/fs/aio.c index 96fbd6b..fa87732 100644 --- a/fs/aio.c +++ b/fs/aio.c @@ -67,13 +67,6 @@ struct kioctx { unsigned