Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-26 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 26, 2013 at 07:30:02AM -0700, David Ahern escreveu: > > On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote: > > >Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu: > > >>On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote: > > >>>Fro

Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 07:30:02AM -0700, David Ahern escreveu: > On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote: > >Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu: > >>On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote: > >>>From: David Ahern > >>> } else { > >>>+

Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-26 Thread David Ahern
On 11/26/13, 7:20 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu: On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote: From: David Ahern } else { + if (al.sym->ignore) Seems to segfault here because sym is null +

Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 12:52:21PM +0200, Adrian Hunter escreveu: > On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote: > > From: David Ahern > > } else { > > + if (al.sym->ignore) > > Seems to segfault here because sym is null > > > + return; > > + Changed it to

Re: [PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-26 Thread Adrian Hunter
On 25/11/13 16:17, Arnaldo Carvalho de Melo wrote: > From: David Ahern > > Allows a command to have a symbol_filter controlled by the user to skip > certain functions in a backtrace. One example is to allow the user to > reduce repeating patterns like: > > do_select core_sys_select sys_sel

[PATCH 21/25] perf evsel: Skip ignored symbols while printing callchain

2013-11-25 Thread Arnaldo Carvalho de Melo
From: David Ahern Allows a command to have a symbol_filter controlled by the user to skip certain functions in a backtrace. One example is to allow the user to reduce repeating patterns like: do_select core_sys_select sys_select to just sys_select when dumping callchains, consuming less r