Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-15 Thread David Howells
Christoph Hellwig wrote: > > > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > > > + IP_PMTUDISC_DONT); > > > > Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 > > socket - I presume it will work in that case. If so: > > Ye

Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-13 Thread Christoph Hellwig
On Wed, May 13, 2020 at 02:17:41PM +0100, David Howells wrote: > Christoph Hellwig wrote: > > > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > > + IP_PMTUDISC_DONT); > > Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 >

Re: [PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-13 Thread David Howells
Christoph Hellwig wrote: > + ip_sock_set_mtu_discover(conn->params.local->socket->sk, > + IP_PMTUDISC_DONT); Um... The socket in question could be an AF_INET6 socket, not an AF_INET4 socket - I presume it will work in that case. If so: Reviewed-by: David

[PATCH 21/33] ipv4: add ip_sock_set_mtu_discover

2020-05-12 Thread Christoph Hellwig
Add a helper to directly set the IP_MTU_DISCOVER sockopt from kernel space without going through a fake uaccess. Signed-off-by: Christoph Hellwig --- include/net/ip.h | 2 ++ net/ipv4/ip_sockglue.c | 22 ++ net/rxrpc/local_object.c | 8 +--- net/rxrpc/output.c