Re: [PATCH 22/22] ver_linux: proc/modules, limit text processing to 'sed'

2015-10-13 Thread Alexander Kapshuk
On Mon, Oct 12, 2015 at 11:22 PM, Jim Davis wrote: > On Mon, Oct 12, 2015 at 11:40 AM, Alexander Kapshuk > wrote: >> This patch is more of a personal preference, rather than a fix for a problem. > > Using the sed hold space isn't exactly easy to follow... if, unlike > the other patches, there is

Re: [PATCH 22/22] ver_linux: proc/modules, limit text processing to 'sed'

2015-10-12 Thread Jim Davis
On Mon, Oct 12, 2015 at 11:40 AM, Alexander Kapshuk wrote: > This patch is more of a personal preference, rather than a fix for a problem. Using the sed hold space isn't exactly easy to follow... if, unlike the other patches, there isn't some potential improvement over the status quo I'd suggest

[PATCH 22/22] ver_linux: proc/modules, limit text processing to 'sed'

2015-10-12 Thread Alexander Kapshuk
This patch is more of a personal preference, rather than a fix for a problem. The current implementation used a combination of both 'cat' and 'sed' to generate an unsorted list of kernel modules separated by while space. The proposed implementation uses 'sort' and 'sed' to generate a sort list of