Re: [PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL_OPS

2014-05-06 Thread Wilfried Klaebe
Am Tue, May 06, 2014 at 11:05:04AM -0400 schrieb David Miller: > SET_ETHTOOL_OPS only exists so that drivers could be compiled > on "older" kernels. > > But the usefulness of that is long gone, we've had netdev->ethtool_ops > since way before we started using GIT. > > I'd rather see a patch which

Re: [PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL_OPS

2014-05-06 Thread David Miller
From: Nicolas Palix Date: Tue, 6 May 2014 11:27:27 +0200 > I saw you rejected almost the entire patch series. > > However, is there any interest to enforce the use of SET_ETHTOOL_OPS ? > Are you likely to merge the patch 24/24 [1] ? SET_ETHTOOL_OPS only exists so that drivers could be compiled

Re: [PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL_OPS

2014-05-06 Thread Nicolas Palix
Hi David, I saw you rejected almost the entire patch series. However, is there any interest to enforce the use of SET_ETHTOOL_OPS ? Are you likely to merge the patch 24/24 [1] ? Regards, [1] https://lkml.org/lkml/2014/5/5/679 On Tue, May 6, 2014 at 12:26 AM, Andi Kleen wrote: > From: Andi Kl

[PATCH 23/24] net, diet: Add coccinelle script to convert drivers to ETHTOOL_OPS

2014-05-05 Thread Andi Kleen
From: Andi Kleen Useful to remove unneeded driver code when ethtool is disabled. The patches doing this are submitted too, but let's add the script too so people can re-use it. Cc: Julia Lawall Cc: Gilles Muller Cc: Nicolas Palix Signed-off-by: Andi Kleen --- scripts/coccinelle/api/ethtool