Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-09-04 Thread Takashi Sakamoto
Hi, On Sep 2 2017 10:19, Takashi Sakamoto wrote: Well, in sound subsystem, there're a few drivers which uses hrtimer: - snd-pcsp - snd-sh-dac-audio - snd-soc-imx-pcm-fiq As a quick glance, 'snd-sh-dac-audio' includes the same bug, too. Additionally, 'snd-soc-imx-pcm-fiq' maintains hrtime

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-09-01 Thread Takashi Sakamoto
On p 1 2017 20:58, Takashi Iwai wrote: >From 07d61ba2a1c0e06e914443225e194d99f2d8c58d Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Fri, 1 Sep 2017 19:10:18 +0900 Subject: [PATCH] ALSA: dummy: avoid stall due to a call of hrtimer_cancel() on a callback of hrtimer A call of 'htrimer_ca

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-09-01 Thread Takashi Iwai
On Fri, 01 Sep 2017 12:25:37 +0200, Takashi Sakamoto wrote: > > Hi, > > On Sep 1 2017 00:36, Takashi Iwai wrote: > > I gave it at try, but it caused a kernel hang, unfortunately. > > > > The reason is that snd_pcm_period_elapased() may stop the stream > > (e.g. when reaching at the end). With t

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-09-01 Thread Takashi Sakamoto
Hi, On Sep 1 2017 00:36, Takashi Iwai wrote: > I gave it at try, but it caused a kernel hang, unfortunately. > > The reason is that snd_pcm_period_elapased() may stop the stream > (e.g. when reaching at the end). With this patchset, it'll lead to > the call of hrtimer_cancel() from the hrtimer c

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-08-31 Thread Takashi Iwai
On Thu, 31 Aug 2017 14:23:45 +0200, Anna-Maria Gleixner wrote: > > From: Thomas Gleixner > > The tasklet is used to defer the execution of snd_pcm_period_elapsed() to > the softirq context. Using the CLOCK_MONOTONIC_SOFT base invokes the timer > callback in softirq context as well which renders

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-08-31 Thread Takashi Iwai
On Thu, 31 Aug 2017 16:21:17 +0200, Takashi Sakamoto wrote: > > Hi, > > On Aug 31 2017 21:23, Anna-Maria Gleixner wrote: > > From: Thomas Gleixner > > > > The tasklet is used to defer the execution of snd_pcm_period_elapsed() to > > the softirq context. Using the CLOCK_MONOTONIC_SOFT base invok

Re: [PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-08-31 Thread Takashi Sakamoto
Hi, On Aug 31 2017 21:23, Anna-Maria Gleixner wrote: > From: Thomas Gleixner > > The tasklet is used to defer the execution of snd_pcm_period_elapsed() to > the softirq context. Using the CLOCK_MONOTONIC_SOFT base invokes the timer > callback in softirq context as well which renders the tasklet

[PATCH 23/25] ALSA/dummy: Replace tasklet with softirq hrtimer

2017-08-31 Thread Anna-Maria Gleixner
From: Thomas Gleixner The tasklet is used to defer the execution of snd_pcm_period_elapsed() to the softirq context. Using the CLOCK_MONOTONIC_SOFT base invokes the timer callback in softirq context as well which renders the tasklet useless. Signed-off-by: Thomas Gleixner Signed-off-by: Anna-Ma