Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-03-23 Thread Lee Jones
> To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches > --- > drivers/mfd/db8500-prcmu.c | 2 +- > drivers/mfd/sta2x11-mfd.

Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-03-15 Thread Joe Perches
On Wed, 2017-03-15 at 12:23 +, Lee Jones wrote: > On Tue, 14 Mar 2017, Joe Perches wrote: [] > > never break user-visible strings such as > > printk messages, because that breaks the ability to grep for them. > > Right, I'm aware of this. I'm also aware of the other rule we have > where lines

Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-03-15 Thread Lee Jones
On Tue, 14 Mar 2017, Joe Perches wrote: > On Tue, 2017-03-14 at 14:04 +, Lee Jones wrote: > > On Thu, 16 Feb 2017, Joe Perches wrote: > > > To enable eventual removal of pr_warning > [] > > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c > [] > > > @@ -502,9 +502,7 @@

Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-03-14 Thread Joe Perches
On Tue, 2017-03-14 at 14:04 +, Lee Jones wrote: > On Thu, 16 Feb 2017, Joe Perches wrote: > > To enable eventual removal of pr_warning [] > > diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c [] > > @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct > > twl403

Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-03-14 Thread Lee Jones
On Thu, 16 Feb 2017, Joe Perches wrote: > To enable eventual removal of pr_warning > > This makes pr_warn use consistent for drivers/mfd > > Prior to this patch, there were 4 uses of pr_warning and > 9 uses of pr_warn in drivers/mfd > > Signed-off-by: Joe Perches > --- > drivers/mfd/db8500-pr

[PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn

2017-02-16 Thread Joe Perches
To enable eventual removal of pr_warning This makes pr_warn use consistent for drivers/mfd Prior to this patch, there were 4 uses of pr_warning and 9 uses of pr_warn in drivers/mfd Signed-off-by: Joe Perches --- drivers/mfd/db8500-prcmu.c | 2 +- drivers/mfd/sta2x11-mfd.c | 4 ++-- drivers/