Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:49, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > > This reintroduces the fault vs truncate race window, which must be > > > > fixed. > > > > > > Hmmm... perhaps. > > > > What do you mean by perhaps?

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-20 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > > Nick Piggin <[EMAIL PROTECTED]> wrote: > > > This reintroduces the fault vs truncate race window, which must be fixed. > > > > Hmmm... perhaps. > > What do you mean by perhaps? I mean 'perhaps'. I'm not sure I remember what the race was, so I can't

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-20 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: Nick Piggin [EMAIL PROTECTED] wrote: This reintroduces the fault vs truncate race window, which must be fixed. Hmmm... perhaps. What do you mean by perhaps? I mean 'perhaps'. I'm not sure I remember what the race was, so I can't evaluate whether

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-20 Thread Nick Piggin
On Friday 21 December 2007 05:49, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: Nick Piggin [EMAIL PROTECTED] wrote: This reintroduces the fault vs truncate race window, which must be fixed. Hmmm... perhaps. What do you mean by perhaps? I mean 'perhaps'. I'm

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-17 Thread Nick Piggin
On Tuesday 18 December 2007 09:54, David Howells wrote: > Nick Piggin <[EMAIL PROTECTED]> wrote: > > This reintroduces the fault vs truncate race window, which must be fixed. > > Hmmm... perhaps. What do you mean by perhaps? > I remember that cropped up in NFS, but I'm doing things > a bit

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-17 Thread David Howells
Nick Piggin <[EMAIL PROTECTED]> wrote: > This reintroduces the fault vs truncate race window, which must be fixed. Hmmm... perhaps. I remember that cropped up in NFS, but I'm doing things a bit differently to NFS. Remind me again how that worked please. > Also, it is adding a fair bit of

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-17 Thread David Howells
Nick Piggin [EMAIL PROTECTED] wrote: This reintroduces the fault vs truncate race window, which must be fixed. Hmmm... perhaps. I remember that cropped up in NFS, but I'm doing things a bit differently to NFS. Remind me again how that worked please. Also, it is adding a fair bit of

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-17 Thread Nick Piggin
On Tuesday 18 December 2007 09:54, David Howells wrote: Nick Piggin [EMAIL PROTECTED] wrote: This reintroduces the fault vs truncate race window, which must be fixed. Hmmm... perhaps. What do you mean by perhaps? I remember that cropped up in NFS, but I'm doing things a bit differently

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:40, David Howells wrote: > Add a function - cancel_rejected_write() - to excise a rejected write from > the pagecache. This function is related to the truncation family of > routines. It permits the pages modified by a network filesystem client > (such as AFS) to

Re: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-13 Thread Nick Piggin
On Thursday 06 December 2007 06:40, David Howells wrote: Add a function - cancel_rejected_write() - to excise a rejected write from the pagecache. This function is related to the truncation family of routines. It permits the pages modified by a network filesystem client (such as AFS) to be

[PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-05 Thread David Howells
Add a function - cancel_rejected_write() - to excise a rejected write from the pagecache. This function is related to the truncation family of routines. It permits the pages modified by a network filesystem client (such as AFS) to be excised and discarded from the pagecache if the attempt to

[PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]

2007-12-05 Thread David Howells
Add a function - cancel_rejected_write() - to excise a rejected write from the pagecache. This function is related to the truncation family of routines. It permits the pages modified by a network filesystem client (such as AFS) to be excised and discarded from the pagecache if the attempt to