Re: [PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-28 Thread Andi Kleen
> Should we test for >3? > > * precise_ip: > * > * 0 - SAMPLE_IP can have arbitrary skid > * 1 - SAMPLE_IP must have constant skid > * 2 - SAMPLE_IP requested to have 0 skid > * 3 - SAMPLE_IP must have 0 skid > > Maybe it's not implemented in hw yet, but

Re: [PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-28 Thread Jiri Olsa
On Fri, Nov 09, 2012 at 05:27:41PM -0800, Andi Kleen wrote: > From: Andi Kleen > > Add a precise qualifier, like cpu/event=0x3c,precise=1/ > > This is needed so that the kernel can request enabling PEBS > for TSX events. The parser bails out on any sysfs parse errors, > so this is needed in any

Re: [PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-28 Thread Jiri Olsa
On Fri, Nov 09, 2012 at 05:27:41PM -0800, Andi Kleen wrote: From: Andi Kleen a...@linux.intel.com Add a precise qualifier, like cpu/event=0x3c,precise=1/ This is needed so that the kernel can request enabling PEBS for TSX events. The parser bails out on any sysfs parse errors, so this is

Re: [PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-28 Thread Andi Kleen
Should we test for 3? * precise_ip: * * 0 - SAMPLE_IP can have arbitrary skid * 1 - SAMPLE_IP must have constant skid * 2 - SAMPLE_IP requested to have 0 skid * 3 - SAMPLE_IP must have 0 skid Maybe it's not implemented in hw yet, but in general

[PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-09 Thread Andi Kleen
From: Andi Kleen Add a precise qualifier, like cpu/event=0x3c,precise=1/ This is needed so that the kernel can request enabling PEBS for TSX events. The parser bails out on any sysfs parse errors, so this is needed in any case to handle any event on the TSX perf kernel. Signed-off-by: Andi

[PATCH 25/32] tools, perf: Add a precise event qualifier

2012-11-09 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Add a precise qualifier, like cpu/event=0x3c,precise=1/ This is needed so that the kernel can request enabling PEBS for TSX events. The parser bails out on any sysfs parse errors, so this is needed in any case to handle any event on the TSX perf kernel.

[PATCH 25/32] tools, perf: Add a precise event qualifier

2012-10-30 Thread Andi Kleen
From: Andi Kleen Add a precise qualifier, like cpu/event=0x3c,precise=1/ This is needed so that the kernel can request enabling PEBS for TSX events. The parser bails out on any sysfs parse errors, so this is needed in any case to handle any event on the TSX perf kernel. Signed-off-by: Andi

[PATCH 25/32] tools, perf: Add a precise event qualifier

2012-10-30 Thread Andi Kleen
From: Andi Kleen a...@linux.intel.com Add a precise qualifier, like cpu/event=0x3c,precise=1/ This is needed so that the kernel can request enabling PEBS for TSX events. The parser bails out on any sysfs parse errors, so this is needed in any case to handle any event on the TSX perf kernel.