Re: [PATCH 26/51] x86, oprofile, nmi: Fix CPU hotplug callback registration

On 02/11/2014 12:57 AM, Gautham R Shenoy wrote: > On Tue, Feb 11, 2014 at 12:37:37AM +0530, Gautham R Shenoy wrote: >> Hi, >> >> On Thu, Feb 06, 2014 at 03:39:22AM +0530, Srivatsa S. Bhat wrote: >>> Fix the oprofile code in x86 by using this latter form of callback >>> registration. But retain the

Re: [PATCH 26/51] x86, oprofile, nmi: Fix CPU hotplug callback registration

On Tue, Feb 11, 2014 at 12:37:37AM +0530, Gautham R Shenoy wrote: > Hi, > > On Thu, Feb 06, 2014 at 03:39:22AM +0530, Srivatsa S. Bhat wrote: > > Fix the oprofile code in x86 by using this latter form of callback > > registration. But retain the calls to get/put_online_cpus(), since they > > also

Re: [PATCH 26/51] x86, oprofile, nmi: Fix CPU hotplug callback registration

Hi, On Thu, Feb 06, 2014 at 03:39:22AM +0530, Srivatsa S. Bhat wrote: > Fix the oprofile code in x86 by using this latter form of callback > registration. But retain the calls to get/put_online_cpus(), since they > also protect the variables 'nmi_enabled' and 'ctr_running'. get/put_online_cpus()

[PATCH 26/51] x86, oprofile, nmi: Fix CPU hotplug callback registration

Subsystems that want to register CPU hotplug callbacks, as well as perform initialization for the CPUs that are already online, often do it as shown below: get_online_cpus(); for_each_online_cpu(cpu) init_cpu(cpu); register_cpu_notifier(&foobar_cpu_notifie