Re: [PATCH 28/28] random: convert to ->poll_mask

2018-03-22 Thread Theodore Y. Ts'o
On Wed, Mar 21, 2018 at 08:40:32AM +0100, Christoph Hellwig wrote: > The big change is that random_read_wait and random_write_wait are merged > into a single waitqueue that uses keyed wakeups. Because wait_event_* > doesn't know about that this will lead to occassional spurious wakeups > in _rando

Re: [PATCH 28/28] random: convert to ->poll_mask

2018-03-21 Thread Greg KH
On Wed, Mar 21, 2018 at 08:40:32AM +0100, Christoph Hellwig wrote: > The big change is that random_read_wait and random_write_wait are merged > into a single waitqueue that uses keyed wakeups. Because wait_event_* > doesn't know about that this will lead to occassional spurious wakeups > in _rando

[PATCH 28/28] random: convert to ->poll_mask

2018-03-21 Thread Christoph Hellwig
The big change is that random_read_wait and random_write_wait are merged into a single waitqueue that uses keyed wakeups. Because wait_event_* doesn't know about that this will lead to occassional spurious wakeups in _random_read and add_hwgenerator_randomness, but wait_event_* is designed to hand