Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman wrote: > On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: >> On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote: >> > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro >> > is not preferred. >> > >> > Signed-off-by: Jingoo Han

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: > On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote: > > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro > > is not preferred. > > > > Signed-off-by: Jingoo Han > > > > I think you misunderstood the checkpatch.pl warning, it

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han wrote: > Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro > is not preferred. > > Signed-off-by: Jingoo Han > I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do. WARNING: Use

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do.

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread Greg Kroah-Hartman
On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com I think you misunderstood the

Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-05 Thread ZHAO Gang
On Thu, Dec 5, 2013 at 11:43 PM, Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Thu, Dec 05, 2013 at 05:06:33PM +0800, ZHAO Gang wrote: On Tue, Dec 3, 2013 at 7:26 AM, Jingoo Han jg1@samsung.com wrote: Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.

[PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han --- drivers/staging/comedi/drivers/8255_pci.c |2 +- drivers/staging/comedi/drivers/addi_apci_035.c|2 +- drivers/staging/comedi/drivers/addi_apci_1032.c |2 +-

[PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro

2013-12-02 Thread Jingoo Han
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/staging/comedi/drivers/8255_pci.c |2 +- drivers/staging/comedi/drivers/addi_apci_035.c|2 +-