Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-10-02 Thread David Rientjes
On Fri, 28 Sep 2012, Daniel Santos wrote: > Throughout compiler*.h, many version checks are made. These can be > simplified by using the macro that gcc's documentation recommends. > However, my primary reason for adding this is that I need bug-check > macros that are enabled at certain gcc versio

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Josh Triplett
On Sun, Sep 30, 2012 at 06:11:01PM -0500, Daniel Santos wrote: > So in light of feedback I've been getting on this patch set, it leaves > me with > this question. > > +#define GCC_VERSION (__GNUC__ * 1 \ > > + + __GNUC_MINOR__ * 100 \ > > + + __GNUC_PATCHLEVEL__) > Thi

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Daniel Santos
So in light of feedback I've been getting on this patch set, it leaves me with this question. > +#define GCC_VERSION (__GNUC__ * 1 \ > ++ __GNUC_MINOR__ * 100 \ > ++ __GNUC_PATCHLEVEL__) This macro presumes you are using gcc 3.0 or later, which introduced the __G

Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-30 Thread Borislav Petkov
On Fri, Sep 28, 2012 at 06:20:04PM -0500, Daniel Santos wrote: > Throughout compiler*.h, many version checks are made. These can be > simplified by using the macro that gcc's documentation recommends. > However, my primary reason for adding this is that I need bug-check > macros that are enabled a

[PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro

2012-09-28 Thread Daniel Santos
Throughout compiler*.h, many version checks are made. These can be simplified by using the macro that gcc's documentation recommends. However, my primary reason for adding this is that I need bug-check macros that are enabled at certain gcc versions and it's cleaner to use this macro than the trad