Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-12 Thread Timur Tabi
On 2/12/21 4:01 AM, Petr Mladek wrote: no_hash_pointers ? I am fine with this. I am still a bit scared of a bikeshedng. But AFAIK, Mathew was most active on proposing clear names. So, when he is fine with this... Anyway, we should use the same name also for the variable. Ok, unless there

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-12 Thread Petr Mladek
On Thu 2021-02-11 17:20:26, Matthew Wilcox wrote: > On Thu, Feb 11, 2021 at 11:08:12AM -0600, Timur Tabi wrote: > > > > > > On 2/11/21 6:31 AM, Pavel Machek wrote: > > > Can we make this something shorter? Clearly you don't want people > > > placing this in their grub config, so they'll be most

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Timur Tabi
On 2/11/21 11:23 AM, Petr Mladek wrote: There was some pushback against this feature in general. It should be used deliberately and people must be aware of the consequences. This is why it is only boot option and why it prints such a huge warning. The long clear name helps as well. This is my

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Timur Tabi
On 2/11/21 11:53 AM, Petr Mladek wrote: I would really like to make it clear here that it is not only about consoles. Most people will see only this message. Only few people read documentation. Many people will learn the parameter name from another context by googling. I know that it is not

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Petr Mladek
On Wed 2021-02-10 15:34:53, Timur Tabi wrote: > If the debug_never_hash_pointers command line parameter is set, then > printk("%p") will print pointers as unhashed, which is useful for > debugging purposes. This also applies to any function that uses > vsprintf, such as print_hex_dump() and

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Petr Mladek
On Thu 2021-02-11 11:08:12, Timur Tabi wrote: > > > On 2/11/21 6:31 AM, Pavel Machek wrote: > > Can we make this something shorter? Clearly you don't want people > > placing this in their grub config, so they'll be most likely typing > > this a lot... > > > > debug_pointers or debug_ptrs would

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Matthew Wilcox
On Thu, Feb 11, 2021 at 11:08:12AM -0600, Timur Tabi wrote: > > > On 2/11/21 6:31 AM, Pavel Machek wrote: > > Can we make this something shorter? Clearly you don't want people > > placing this in their grub config, so they'll be most likely typing > > this a lot... > > > > debug_pointers or

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Timur Tabi
On 2/11/21 6:31 AM, Pavel Machek wrote: Can we make this something shorter? Clearly you don't want people placing this in their grub config, so they'll be most likely typing this a lot... debug_pointers or debug_ptrs would be better. dbg_unhash_ptrs? "debug_ptrs" is too vague IMHO, and I

Re: [PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-11 Thread Pavel Machek
Hi! > If the debug_never_hash_pointers command line parameter is set, then Can we make this something shorter? Clearly you don't want people placing this in their grub config, so they'll be most likely typing this a lot... debug_pointers or debug_ptrs would be better. Thanks,

[PATCH 3/3] [v3] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed

2021-02-10 Thread Timur Tabi
If the debug_never_hash_pointers command line parameter is set, then printk("%p") will print pointers as unhashed, which is useful for debugging purposes. This also applies to any function that uses vsprintf, such as print_hex_dump() and seq_buf_printf(). A large warning message is displayed if