Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Petr Mladek
On Tue 2021-03-02 14:49:42, Geert Uytterhoeven wrote: > Hi Vlastimil, Petr, > > On Tue, Mar 2, 2021 at 2:37 PM Vlastimil Babka wrote: > > On 3/2/21 2:29 PM, Petr Mladek wrote: > > > On Tue 2021-03-02 13:51:35, Geert Uytterhoeven wrote: > > >> > > > + > > >> > > > + > > >> > > >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Geert Uytterhoeven
Hi Steven, On Tue, Mar 2, 2021 at 3:08 PM Steven Rostedt wrote: > On Tue, 2 Mar 2021 14:49:42 +0100 > Geert Uytterhoeven wrote: > > > So this is basically a kernel tinyfication issue, right? Is that still > > > pursued > > > today? Are there better config options suitable for this than > > >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Marco Elver
On Tue, 2 Mar 2021 at 15:35, Matthew Wilcox wrote: > > On Tue, Mar 02, 2021 at 03:26:50PM +0100, Marco Elver wrote: > > +static const char no_hash_pointers_warning[9][55] __initconst = { > > + "**", > > + " NOTICE NOTICE NOTICE NOTICE

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Marco Elver
On Tue, 2 Mar 2021 at 15:55, Geert Uytterhoeven wrote: > > Hi Marco, > > On Tue, Mar 2, 2021 at 3:40 PM Marco Elver wrote: > > On Tue, 2 Mar 2021 at 15:35, Matthew Wilcox wrote: > > > On Tue, Mar 02, 2021 at 03:26:50PM +0100, Marco Elver wrote: > > > > +static const char

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Andy Shevchenko
On Tue, Mar 02, 2021 at 03:28:09PM +0100, Geert Uytterhoeven wrote: > On Tue, Mar 2, 2021 at 3:08 PM Steven Rostedt wrote: > > On Tue, 2 Mar 2021 14:49:42 +0100 > > Geert Uytterhoeven wrote: > > > > So this is basically a kernel tinyfication issue, right? Is that still > > > > pursued > > > >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Rasmus Villemoes
On 02/03/2021 15.28, Geert Uytterhoeven wrote: > Fortunately gcc is already smart enough to deduplicate identical strings, > but only in the same source file. Yeah, gcc can't do much more since it only handles one source file at a time. However, the linker certainly deduplicates strings across

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Geert Uytterhoeven
Hi Marco, On Tue, Mar 2, 2021 at 3:40 PM Marco Elver wrote: > On Tue, 2 Mar 2021 at 15:35, Matthew Wilcox wrote: > > On Tue, Mar 02, 2021 at 03:26:50PM +0100, Marco Elver wrote: > > > +static const char no_hash_pointers_warning[9][55] __initconst = { > > > +

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Matthew Wilcox
On Tue, Mar 02, 2021 at 03:26:50PM +0100, Marco Elver wrote: > +static const char no_hash_pointers_warning[9][55] __initconst = { > + "**", > + " NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE ", > + "

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Marco Elver
On Tue, Mar 02, 2021 at 09:08AM -0500, Steven Rostedt wrote: > On Tue, 2 Mar 2021 14:49:42 +0100 > Geert Uytterhoeven wrote: > > > > So this is basically a kernel tinyfication issue, right? Is that still > > > pursued > > > today? Are there better config options suitable for this than > > >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Steven Rostedt
On Tue, 2 Mar 2021 14:49:42 +0100 Geert Uytterhoeven wrote: > > So this is basically a kernel tinyfication issue, right? Is that still > > pursued > > today? Are there better config options suitable for this than > > CONFIG_DEBUG_KERNEL? > > As long as I hear about products running Linux on

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Geert Uytterhoeven
Hi Vlastimil, Petr, On Tue, Mar 2, 2021 at 2:37 PM Vlastimil Babka wrote: > On 3/2/21 2:29 PM, Petr Mladek wrote: > > On Tue 2021-03-02 13:51:35, Geert Uytterhoeven wrote: > >> > > > + > >> > > > + > >> > > > pr_warn("**\n"); > >> >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Vlastimil Babka
On 3/2/21 2:29 PM, Petr Mladek wrote: > On Tue 2021-03-02 13:51:35, Geert Uytterhoeven wrote: >> > > > + >> > > > + >> > > > pr_warn("**\n"); >> > > > + pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE >> > > >

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Petr Mladek
On Tue 2021-03-02 13:51:35, Geert Uytterhoeven wrote: > Hi Marco, > > On Tue, Mar 2, 2021 at 1:45 PM Marco Elver wrote: > > On Tue, 2 Mar 2021 at 12:51, Geert Uytterhoeven > > wrote: > > > On Sun, Feb 14, 2021 at 5:17 PM Timur Tabi wrote: > > > > If the no_hash_pointers command line parameter

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Geert Uytterhoeven
Hi Marco, On Tue, Mar 2, 2021 at 1:45 PM Marco Elver wrote: > On Tue, 2 Mar 2021 at 12:51, Geert Uytterhoeven wrote: > > On Sun, Feb 14, 2021 at 5:17 PM Timur Tabi wrote: > > > If the no_hash_pointers command line parameter is set, then > > > printk("%p") will print pointers as unhashed, which

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Marco Elver
On Tue, 2 Mar 2021 at 12:51, Geert Uytterhoeven wrote: > Hi Timur, > > On Sun, Feb 14, 2021 at 5:17 PM Timur Tabi wrote: > > If the no_hash_pointers command line parameter is set, then > > printk("%p") will print pointers as unhashed, which is useful for > > debugging purposes. This change

Re: [PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-03-02 Thread Geert Uytterhoeven
Hi Timur, On Sun, Feb 14, 2021 at 5:17 PM Timur Tabi wrote: > If the no_hash_pointers command line parameter is set, then > printk("%p") will print pointers as unhashed, which is useful for > debugging purposes. This change applies to any function that uses > vsprintf, such as print_hex_dump()

[PATCH 3/3] [v4] lib/vsprintf: no_hash_pointers prints all addresses as unhashed

2021-02-14 Thread Timur Tabi
If the no_hash_pointers command line parameter is set, then printk("%p") will print pointers as unhashed, which is useful for debugging purposes. This change applies to any function that uses vsprintf, such as print_hex_dump() and seq_buf_printf(). A large warning message is displayed if this