Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-23 Thread Maxime Ripard
On Wed, Aug 23, 2017 at 01:46:50PM +0800, Icenowy Zheng wrote: > > > 于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard > 写到: > >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: > >> +_vcc5v0 { > >> + gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ >

Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-23 Thread Maxime Ripard
On Wed, Aug 23, 2017 at 01:46:50PM +0800, Icenowy Zheng wrote: > > > 于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard > 写到: > >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: > >> +_vcc5v0 { > >> + gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ > >> + enable-active-high; > >> +};

Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Icenowy Zheng
于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard 写到: >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: >> +_vcc5v0 { >> +gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ >> +enable-active-high; >> +}; > >Same thing here, you're not using that

Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Icenowy Zheng
于 2017年8月23日 GMT+08:00 上午4:12:15, Maxime Ripard 写到: >On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: >> +_vcc5v0 { >> +gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ >> +enable-active-high; >> +}; > >Same thing here, you're not using that regulator anywhere. You don't >even

Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Maxime Ripard
On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: > +_vcc5v0 { > + gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ > + enable-active-high; > +}; Same thing here, you're not using that regulator anywhere. You don't even use any of the regulators in sunxi-common-regulators. Maxime

Re: [PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Maxime Ripard
On Tue, Aug 22, 2017 at 02:17:42PM +0800, Icenowy Zheng wrote: > +_vcc5v0 { > + gpio = < 7 23 GPIO_ACTIVE_HIGH>; /* PH23 */ > + enable-active-high; > +}; Same thing here, you're not using that regulator anywhere. You don't even use any of the regulators in sunxi-common-regulators. Maxime

[PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Icenowy Zheng
The Banana Pi M2 Ultra is an SBC based on the Allwinner V40 SoC (same as the R40 SoC). The form factor is similar to the Raspberry Pi series. It features: - X-Powers AXP221s PMIC connected to i2c0 - 1GiB DDR3 DRAM - microSD slot - MicroUSB Type-B port for power and connected to usb0 - HDMI

[PATCH 3/3] ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry

2017-08-22 Thread Icenowy Zheng
The Banana Pi M2 Ultra is an SBC based on the Allwinner V40 SoC (same as the R40 SoC). The form factor is similar to the Raspberry Pi series. It features: - X-Powers AXP221s PMIC connected to i2c0 - 1GiB DDR3 DRAM - microSD slot - MicroUSB Type-B port for power and connected to usb0 - HDMI