Re: [PATCH 3/3] KVM: x86: always stop emulation on page fault

2019-08-28 Thread Sean Christopherson
On Wed, Aug 28, 2019 at 10:19:51AM +, Jan Dakinevich wrote: > On Tue, 27 Aug 2019 07:50:30 -0700 > Sean Christopherson wrote: > > Yikes, this patch and the previous have quite the sordid history. > > > > > > The non-void return from inject_emulated_exception() was added by commit > > > >

Re: [PATCH 3/3] KVM: x86: always stop emulation on page fault

2019-08-28 Thread Jan Dakinevich
On Tue, 27 Aug 2019 07:50:30 -0700 Sean Christopherson wrote: > +Cc Peng Hao and Yi Wang > > On Tue, Aug 27, 2019 at 01:07:09PM +, Jan Dakinevich wrote: > > inject_emulated_exception() returns true if and only if nested page > > fault happens. However, page fault can come from guest page

Re: [PATCH 3/3] KVM: x86: always stop emulation on page fault

2019-08-27 Thread Sean Christopherson
Actually adding Peng Hao and Yi Wang... On Tue, Aug 27, 2019 at 07:50:30AM -0700, Sean Christopherson wrote: > +Cc Peng Hao and Yi Wang > > On Tue, Aug 27, 2019 at 01:07:09PM +, Jan Dakinevich wrote: > > inject_emulated_exception() returns true if and only if nested page > > fault happens.

Re: [PATCH 3/3] KVM: x86: always stop emulation on page fault

2019-08-27 Thread Sean Christopherson
+Cc Peng Hao and Yi Wang On Tue, Aug 27, 2019 at 01:07:09PM +, Jan Dakinevich wrote: > inject_emulated_exception() returns true if and only if nested page > fault happens. However, page fault can come from guest page tables > walk, either nested or not nested. In both cases we should stop an

[PATCH 3/3] KVM: x86: always stop emulation on page fault

2019-08-27 Thread Jan Dakinevich
inject_emulated_exception() returns true if and only if nested page fault happens. However, page fault can come from guest page tables walk, either nested or not nested. In both cases we should stop an attempt to read under RIP and give guest to step over its own page fault handler. Fixes: