Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-24 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did the required changes myself (it also turned out that I missed few things during initial review), then applied the patch... Please let my know whether you are fine w

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: > > On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: > > Please respin the patch so I could merge it. > > Ok. Since I think that it's worth to have it in 2.6.21-final and respin didn't happen I did the required changes myself

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Suleiman Souhlal
On Mar 8, 2007, at 12:34 PM, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery is

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 08 March 2007, Suleiman Souhlal wrote: > > On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: > > > > > Hi, > > > > (sorry for the long delay) > > > > On Wednesday 21 February 2007, Suleiman Souhlal wrote: > >> IDE error recovery is using WIN_IDLEIMMEDIATE which was on

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-08 Thread Suleiman Souhlal
On Mar 7, 2007, at 1:16 PM, Bartlomiej Zolnierkiewicz wrote: Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for IDE V1 and IDE V2. Modern drives will not be able to recover using thi

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-07 Thread Alan Cox
> On Wednesday 21 February 2007, Suleiman Souhlal wrote: > > IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for > > IDE V1 and IDE V2. Modern drives will not be able to recover using > > this error handling. The correct thing to do is issue a SRST followed > > by a SET_FEATURE

Re: [PATCH 3/3] Use correct IDE error recovery

2007-03-07 Thread Bartlomiej Zolnierkiewicz
Hi, (sorry for the long delay) On Wednesday 21 February 2007, Suleiman Souhlal wrote: > IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for > IDE V1 and IDE V2. Modern drives will not be able to recover using > this error handling. The correct thing to do is issue a SRST fol

[PATCH 3/3] Use correct IDE error recovery

2007-02-20 Thread Suleiman Souhlal
IDE error recovery is using WIN_IDLEIMMEDIATE which was only valid for IDE V1 and IDE V2. Modern drives will not be able to recover using this error handling. The correct thing to do is issue a SRST followed by a SET_FEATURES. Signed-off-by: Suleiman Souhlal <[EMAIL PROTECTED]> --- drivers/id