Re: [PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP

2018-02-09 Thread KarimAllah Ahmed
On 02/10/2018 12:57 AM, Jim Mattson wrote: On Fri, Feb 9, 2018 at 3:41 PM, KarimAllah Ahmed wrote: I assume you are referring to this: https://patchwork.kernel.org/patch/10194819/ .. which is now: commit 904e14fb7cb9 ("KVM: VMX: make MSR bitmaps per-VCPU") right? If this is the case, then

Re: [PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP

2018-02-09 Thread Jim Mattson
On Fri, Feb 9, 2018 at 3:41 PM, KarimAllah Ahmed wrote: > I assume you are referring to this: > > https://patchwork.kernel.org/patch/10194819/ > > .. which is now: > > commit 904e14fb7cb9 ("KVM: VMX: make MSR bitmaps per-VCPU") > > right? > > If this is the case, then I do not see where the MSR_B

Re: [PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP

2018-02-09 Thread KarimAllah Ahmed
On 02/10/2018 12:26 AM, Jim Mattson wrote: On Thu, Feb 8, 2018 at 2:53 PM, KarimAllah Ahmed wrote: ... otherwise we will just be running with the L1 MSR BITMAP! It does not seem that we ever update the MSR_BITMAP when the nested guest is running. The only place where we update the MSR_BITMAP f

Re: [PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP

2018-02-09 Thread Jim Mattson
On Thu, Feb 8, 2018 at 2:53 PM, KarimAllah Ahmed wrote: > ... otherwise we will just be running with the L1 MSR BITMAP! > > It does not seem that we ever update the MSR_BITMAP when the nested guest > is running. The only place where we update the MSR_BITMAP field in VMCS is > for the L1 guest! > >

[PATCH 3/3] X86/nVMX: Update the MSR_BITMAP field with the L02 MSR BITMAP

2018-02-08 Thread KarimAllah Ahmed
... otherwise we will just be running with the L1 MSR BITMAP! It does not seem that we ever update the MSR_BITMAP when the nested guest is running. The only place where we update the MSR_BITMAP field in VMCS is for the L1 guest! Signed-off-by: KarimAllah Ahmed Cc: Paolo Bonzini Cc: Radim Krčmář