Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-21 Thread Xing Zheng
Hi Heiko, Doug 在 2016年12月17日 01:28, Doug Anderson 写道: Hi, On Thu, Dec 15, 2016 at 10:57 PM, Xing Zheng wrote: Hi Heiko, Doug, On 2016年12月16日 02:18, Heiko Stuebner wrote: Am Donnerstag, 15. Dezember 2016, 08:34:09 CET schrieb Doug Anderson: I still need to digest all of the things that wer

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-16 Thread Heiko Stuebner
Am Freitag, 16. Dezember 2016, 14:57:01 CET schrieb Xing Zheng: > Hi Heiko, Doug, > > On 2016年12月16日 02:18, Heiko Stuebner wrote: > > Am Donnerstag, 15. Dezember 2016, 08:34:09 CET schrieb Doug Anderson: > >> I still need to digest all of the things that were added to this > >> thread overnight, b

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-16 Thread Doug Anderson
Hi, On Thu, Dec 15, 2016 at 10:57 PM, Xing Zheng wrote: > Hi Heiko, Doug, > > On 2016年12月16日 02:18, Heiko Stuebner wrote: > > Am Donnerstag, 15. Dezember 2016, 08:34:09 CET schrieb Doug Anderson: > > > I still need to digest all of the things that were added to this > thread overnight, but nothin

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-15 Thread Heiko Stuebner
Am Donnerstag, 15. Dezember 2016, 08:34:09 CET schrieb Doug Anderson: > Hi, > > On Wed, Dec 14, 2016 at 10:41 PM, Frank Wang wrote: > > Hi Brain, Doug and Heiko, > > > > I would like to summarize why this story was constructed. > > > > The ehci/ohci-platform suspend process are blocked due to

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-15 Thread Doug Anderson
Hi, On Wed, Dec 14, 2016 at 10:41 PM, Frank Wang wrote: > Hi Brain, Doug and Heiko, > > I would like to summarize why this story was constructed. > > The ehci/ohci-platform suspend process are blocked due to UTMI clock which > directly output from usb-phy has been disabled, and why the UTMI clock

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Frank Wang
Hi Brain, Doug and Heiko, I would like to summarize why this story was constructed. The ehci/ohci-platform suspend process are blocked due to UTMI clock which directly output from usb-phy has been disabled, and why the UTMI clock was disabled? UTMI clock and 480m clock all output from the sa

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Brian Norris
On Thu, Dec 15, 2016 at 10:41:04AM +0800, Xing Zheng wrote: > // Frank > > Hi Doug, Brain, > Thanks for the reply. > Sorry I forgot these patches have been sent earlier, and Frank > have some explained and discussed with Heiko. > Please see https://patchwork.kernel.org/patch/9255245/ >

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Xing Zheng
// Frank Hi Doug, Brain, Thanks for the reply. Sorry I forgot these patches have been sent earlier, and Frank have some explained and discussed with Heiko. Please see https://patchwork.kernel.org/patch/9255245/ Perhaps we can move to that patch tree to continue the discussion.

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Brian Norris
On Wed, Dec 14, 2016 at 04:47:38PM -0800, Brian Norris wrote: > On Wed, Dec 14, 2016 at 04:10:38PM -0800, Doug Anderson wrote: > > On Wed, Dec 14, 2016 at 2:11 AM, Xing Zheng > > wrote: > > > From: William wu > > > > > > We found that the suspend process was blocked when it run into > > > ehci/o

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Brian Norris
Hi, I think Doug is probably right on most accounts, and I haven't thoroughly investigated all the claims. But a few thoughts: On Wed, Dec 14, 2016 at 04:10:38PM -0800, Doug Anderson wrote: > On Wed, Dec 14, 2016 at 2:11 AM, Xing Zheng wrote: > > From: William wu > > > > We found that the suspe

Re: [PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Doug Anderson
Hi, On Wed, Dec 14, 2016 at 2:11 AM, Xing Zheng wrote: > From: William wu > > We found that the suspend process was blocked when it run into > ehci/ohci module due to clk-480m of usb2-phy was disabled. > > The root cause is that usb2-phy suspended earlier than ehci/ohci > (usb2-phy will be auto

[PATCH 3/3] arm64: dts: rockchip: add clk-480m for ehci and ohci of rk3399

2016-12-14 Thread Xing Zheng
From: William wu We found that the suspend process was blocked when it run into ehci/ohci module due to clk-480m of usb2-phy was disabled. The root cause is that usb2-phy suspended earlier than ehci/ohci (usb2-phy will be auto suspended if no devices plug-in). and the clk-480m provided by it was