Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-11 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 3:50 PM Heiko Stübner wrote: > > Am Montag, 11. Januar 2021, 04:27:47 CET schrieb Chen-Yu Tsai: > > On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner wrote: > > > > > > Hi, > > > > > > Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > > > > + vcc_sd:

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Heiko Stübner
Am Montag, 11. Januar 2021, 04:27:47 CET schrieb Chen-Yu Tsai: > On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner wrote: > > > > Hi, > > > > Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > > > + vcc_sd: sdmmc-regulator { > > > > > + compatible =

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 4:17 AM Johan Jonker wrote: > > Hi Chen-Yu, > > Most is already answered by Heiko. > > On 1/10/21 4:37 PM, Chen-Yu Tsai wrote: > > Hi, > > > > On Sun, Jan 10, 2021 at 10:45 PM Johan Jonker wrote: > >> > >> Hi Chen-Yu, > >> > >> Some comments, have a look if it is

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
On Mon, Jan 11, 2021 at 4:06 AM Heiko Stübner wrote: > > Hi, > > Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > > + vcc_sd: sdmmc-regulator { > > > > + compatible = "regulator-fixed"; > > > > + gpio = < RK_PD6 GPIO_ACTIVE_LOW>; > > > > +

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Johan Jonker
Hi Chen-Yu, Most is already answered by Heiko. On 1/10/21 4:37 PM, Chen-Yu Tsai wrote: > Hi, > > On Sun, Jan 10, 2021 at 10:45 PM Johan Jonker wrote: >> >> Hi Chen-Yu, >> >> Some comments, have a look if it is useful... >> >> On 1/10/21 4:58 AM, Chen-Yu Tsai wrote: >>> From: Chen-Yu Tsai >>>

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Heiko Stübner
Hi, Am Sonntag, 10. Januar 2021, 16:37:15 CET schrieb Chen-Yu Tsai: > > > + vcc_sd: sdmmc-regulator { > > > + compatible = "regulator-fixed"; > > > + gpio = < RK_PD6 GPIO_ACTIVE_LOW>; > > > + pinctrl-names = "default"; > > > + pinctrl-0 =

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Chen-Yu Tsai
Hi, On Sun, Jan 10, 2021 at 10:45 PM Johan Jonker wrote: > > Hi Chen-Yu, > > Some comments, have a look if it is useful... > > On 1/10/21 4:58 AM, Chen-Yu Tsai wrote: > > From: Chen-Yu Tsai > > > > Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. > > As the official wiki

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Johan Jonker
Hi Chen-Yu, Some comments, have a look if it is useful... On 1/10/21 4:58 AM, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. > As the official wiki page puts it, "E for Ethernets". > > It features the RK3328 SoC, gigabit

[PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-09 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. As the official wiki page puts it, "E for Ethernets". It features the RK3328 SoC, gigabit and fast Ethernet RJ45 ports, both directly served by Ethernet controllers in the SoC, a USB 3.0 host port, a