Re: [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK

2020-07-17 Thread Miroslav Benes
On Thu, 16 Jul 2020, Mark Brown wrote: > On Thu, Jul 16, 2020 at 01:56:13PM +0200, Miroslav Benes wrote: > > On Wed, 15 Jul 2020, Mark Brown wrote: > > > > -void save_stack_trace(struct stack_trace *trace) > > > -{ > > > - __save_stack_trace(current, trace, 0); > > > + walk_stackframe(task, ,

Re: [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK

2020-07-16 Thread Mark Brown
On Thu, Jul 16, 2020 at 01:56:13PM +0200, Miroslav Benes wrote: > On Wed, 15 Jul 2020, Mark Brown wrote: > > -void save_stack_trace(struct stack_trace *trace) > > -{ > > - __save_stack_trace(current, trace, 0); > > + walk_stackframe(task, , consume_entry, cookie); > > } > just an idea for

Re: [PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK

2020-07-16 Thread Miroslav Benes
Hi, On Wed, 15 Jul 2020, Mark Brown wrote: > Historically architectures have had duplicated code in their stack trace > implementations for filtering what gets traced. In order to avoid this > duplication some generic code has been provided using a new interface > arch_stack_walk(), enabled by

[PATCH 3/3] arm64: stacktrace: Convert to ARCH_STACKWALK

2020-07-15 Thread Mark Brown
Historically architectures have had duplicated code in their stack trace implementations for filtering what gets traced. In order to avoid this duplication some generic code has been provided using a new interface arch_stack_walk(), enabled by selecting ARCH_STACKWALK in Kconfig, which factors all