Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-11-01 Thread Borislav Petkov
On Wed, Oct 31, 2012 at 03:49:08PM -0700, Andrew Morton wrote: > Joe means floating point. I suggest that the patchset be reworked, > using s/decimal/float/g. > > > The kernel does have floating point constants, in various graphics > drivers, iirc. They are used in places where the floatiness g

Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-11-01 Thread Pavel Machek
Hi! > > > Linux kernel doesn't like decimals, say so. > > > > ?! > > > > Linux surely supports decimal constants, like "100". Did you mean > > "octal"? > > > > If you wanted to add warning for something... I never want to see > > > > #define CRAPPY_EMBEDDED_REGISTER ((0x1) << (0)) > > > > aga

Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-10-31 Thread Andrew Morton
On Wed, 31 Oct 2012 11:37:03 +0100 Pavel Machek wrote: > Hi! > > > Linux kernel doesn't like decimals, say so. > > ?! > > Linux surely supports decimal constants, like "100". Did you mean > "octal"? > > If you wanted to add warning for something... I never want to see > > #define CRAPPY_EMBE

Re: [PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-10-31 Thread Pavel Machek
Hi! > Linux kernel doesn't like decimals, say so. ?! Linux surely supports decimal constants, like "100". Did you mean "octal"? If you wanted to add warning for something... I never want to see #define CRAPPY_EMBEDDED_REGISTER ((0x1) << (0)) again

[PATCH 3/3] checkpatch: Emit a warning when decimal values are used

2012-10-31 Thread Joe Perches
Linux kernel doesn't like decimals, say so. Signed-off-by: Joe Perches --- scripts/checkpatch.pl |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 3e727c5..3339ecf 100755 --- a/scripts/checkpatch.pl +++ b/scripts/ch