Re: [PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-04 Thread Jerome Brunet
On Wed, 2018-07-04 at 15:17 +0800, Yixun Lan wrote: > > you are describing the mux and the divider here > > however, meson-gx-mmc.c has a few more clock related bits: > > - CLK_CORE_PHASE_MASK > > - CLK_TX_PHASE_MASK > > - CLK_RX_PHASE_MASK > > - CLK_V2_TX_DELAY_MASK / CLK_V3_TX_DELAY_MASK > > - CL

Re: [PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-04 Thread Yixun Lan
Hi Martin On 07/04/18 02:58, Martin Blumenstingl wrote: > Hi Yixun, > > apart from what Jerome found this looks good to me. > one small "issue" and a question are inline below > > On Tue, Jul 3, 2018 at 9:00 AM Yixun Lan wrote: >> >> This patch will add a EMMC clock controller driver support,

Re: [PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-03 Thread Martin Blumenstingl
Hi Yixun, apart from what Jerome found this looks good to me. one small "issue" and a question are inline below On Tue, Jul 3, 2018 at 9:00 AM Yixun Lan wrote: > > This patch will add a EMMC clock controller driver support, > It provide a mux and divider clock. > > This clock driver can be prote

Re: [PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-03 Thread Yixun Lan
Hi Jerome: see my comments On 07/03/18 16:51, Jerome Brunet wrote: > On Tue, 2018-07-03 at 14:57 +, Yixun Lan wrote: >> This patch will add a EMMC clock controller driver support, >> It provide a mux and divider clock. >> >> This clock driver can be protentially used by either EMMC and >> NAN

Re: [PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-03 Thread Jerome Brunet
On Tue, 2018-07-03 at 14:57 +, Yixun Lan wrote: > This patch will add a EMMC clock controller driver support, > It provide a mux and divider clock. > > This clock driver can be protentially used by either EMMC and > NAND driver. > > Signed-off-by: Yixun Lan > --- > drivers/clk/meson/Kconfig

[PATCH 3/3] clk: meson: add sub EMMC clock controller driver

2018-07-03 Thread Yixun Lan
This patch will add a EMMC clock controller driver support, It provide a mux and divider clock. This clock driver can be protentially used by either EMMC and NAND driver. Signed-off-by: Yixun Lan --- drivers/clk/meson/Kconfig | 9 +++ drivers/clk/meson/Makefile| 1 + drivers/clk/mes