Re: [PATCH 3/3] drivers/char/random.c: make primary_crng static

2018-11-07 Thread Theodore Y. Ts'o
On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote: > Since the definition of struct crng_state is private to random.c, and > primary_crng is neither declared or used elsewhere, there's no reason > for that symbol to have external linkage. > > Signed-off-by: Rasmus Villemoes

Re: [PATCH 3/3] drivers/char/random.c: make primary_crng static

2018-11-07 Thread Theodore Y. Ts'o
On Fri, Nov 02, 2018 at 12:04:47PM +0100, Rasmus Villemoes wrote: > Since the definition of struct crng_state is private to random.c, and > primary_crng is neither declared or used elsewhere, there's no reason > for that symbol to have external linkage. > > Signed-off-by: Rasmus Villemoes

[PATCH 3/3] drivers/char/random.c: make primary_crng static

2018-11-02 Thread Rasmus Villemoes
Since the definition of struct crng_state is private to random.c, and primary_crng is neither declared or used elsewhere, there's no reason for that symbol to have external linkage. Signed-off-by: Rasmus Villemoes --- drivers/char/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 3/3] drivers/char/random.c: make primary_crng static

2018-11-02 Thread Rasmus Villemoes
Since the definition of struct crng_state is private to random.c, and primary_crng is neither declared or used elsewhere, there's no reason for that symbol to have external linkage. Signed-off-by: Rasmus Villemoes --- drivers/char/random.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)